Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: chrome/browser/resources/feedback.html

Issue 10382142: whip the feedback page into shape (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: upload Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« chrome/browser/resources/feedback.css ('K') | « chrome/browser/resources/feedback.css ('k') | chrome/browser/resources/feedback.js » ('j') | chrome/browser/resources/feedback.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 <!DOCTYPE HTML> 1 <!DOCTYPE HTML>
2 <html i18n-values="dir:textdirection;"> 2 <html i18n-values="dir:textdirection;">
3 <head> 3 <head>
4 <meta charset="utf-8"/> 4 <meta charset="utf-8"/>
5 <title i18n-content="page-title"></title> 5 <title i18n-content="page-title"></title>
6 <!-- We want to keep our style in sync with the options page. -->
7 <link rel="stylesheet" href="chrome://resources/css/chrome_shared.css">
8 <link rel="stylesheet" href="chrome://resources/css/widgets.css"> 6 <link rel="stylesheet" href="chrome://resources/css/widgets.css">
9 <link rel="stylesheet" href="chrome://resources/css/chrome_shared2.css"> 7 <link rel="stylesheet" href="chrome://resources/css/chrome_shared2.css">
10 <link rel="stylesheet" href="feedback.css"> 8 <link rel="stylesheet" href="feedback.css">
11 9
12 <script src="chrome://resources/js/local_strings.js"></script> 10 <script src="chrome://resources/js/load_time_data.js"></script>
13 <script src="chrome://resources/js/util.js"></script> 11 <script src="chrome://resources/js/util.js"></script>
14 <script src="chrome://feedback/feedback.js"></script> 12 <script src="chrome://feedback/feedback.js"></script>
15 <script src="chrome://feedback/strings.js"></script> 13 <script src="chrome://feedback/strings.js"></script>
16 </head> 14 </head>
17 <body i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize"> 15 <body id="feedback-page"
18 <div id="main-content"> 16 i18n-values=".style.fontFamily:fontfamily;.style.fontSize:fontsize">
19 <div id="navbar-container"> 17 <h1 i18n-content="title"></h1>
20 <h1 id="navbar-content-title" i18n-content="page-title"> 18 <div id="content">
21 </h1> 19 <span id="description" colspan="2" i18n-content="description"></span>
22 </div> 20 <textarea id="description-text" rows="10"></textarea>
23 <div id="mainview" class> 21 <div id="page-url" class="checkbox">
24 <!-- Even though we really don't need these many nested DIV's, we're staying 22 <label>
25 as close to the settings page layout as possible, re-using all our styles 23 <input id="page-url-checkbox" type="checkbox"
26 from options_page.css --> 24 value="pageurl" checked>
27 <div id="mainview-content"> 25 <span id="page-url-label"
Dan Beam 2012/05/16 22:38:14 unwrap this all the tons of tags below that no lon
Evan Stade 2012/05/16 23:56:24 Done.
28 <div id="page-container"> 26 i18n-content="page-url"></span>
29 <div id="feedback-page" class="page"> 27 </label>
30 <h1 i18n-content="title"></h1> 28 <input id="page-url-text">
31 <table id="main-table"> 29 </div>
32 <!-- Description -->
33 <tr>
34 <th id="description" colspan="2" class="feedback-label"
35 i18n-content="description"></th>
36 </tr>
37 <tr>
38 <td colspan="2">
39 <textarea id="description-text" rows="10"
40 class="feedback-text"></textarea>
41 </td>
42 </tr>
43 <tr>
44 <td>
45 <table style="-webkit-border-vertical-spacing: 0px;">
46 <!-- Page URL -->
47 <tr>
48 <td>
49 <table class="feedback-table">
50 <tr>
51 <td class="feedback-fieldlabel checkbox">
52 <label>
53 <input id="page-url-checkbox" type="checkbox"
54 value="pageurl" checked>
55 <span id="page-url-label"
56 i18n-content="page-url"></span>
57 </label>
58 </td>
59 <td>
60 <input id="page-url-text" class="feedback-field"
61 maxlength="200">
62 </td>
63 </tr>
64 </table>
65 </td>
66 </tr>
67 <if expr="pp_ifdef('chromeos')"> 30 <if expr="pp_ifdef('chromeos')">
68 <!-- User e-mail --> 31 <!-- User e-mail -->
Dan Beam 2012/05/16 22:38:14 there's an extra space after "<!--" in all these c
Evan Stade 2012/05/16 23:56:24 Done.
69 <tr> 32 <div id="user-email-table">
70 <td> 33 <div class="checkbox">
71 <table id="user-email-table" class="feedback-table"> 34 <label>
72 <tr> 35 <input id="user-email-checkbox" type="checkbox"
73 <td class="feedback-fieldlabel checkbox"> 36 checked>
74 <label> 37 <span id="user-email-label"
75 <input id="user-email-checkbox" type="checkbox" 38 i18n-content="user-email"></span>
76 checked> 39 </label>
77 <span id="user-email-label" 40 <span id="user-email-text"></span>
78 i18n-content="user-email"></span>
79 </label>
80 </td>
81 <td>
82 <label id="user-email-text"
83 class="feedback-field"></label>
84 </td>
85 </tr>
86 </table>
87 </td>
88 </tr>
89 <!-- System Information -->
90 <tr>
91 <td>
92 <table class="feedback-table">
93 <tr>
94 <td class="feedback-fieldlabel checkbox">
95 <label>
96 <input id="sys-info-checkbox" type="checkbox"
97 checked>
98 <span id="sysinfo-label">
99 <a id="sysinfo-url" href="#"
100 i18n-content="sysinfo"></a>
101 </span>
102 </label>
103 </td>
104 </tr>
105 </table>
106 </td>
107 </tr>
108 </if>
109 <!-- Screenshot -->
110 <tr id="screenshot-row">
111 <td>
112 <table class="feedback-table">
113 <tr>
114 <td class="feedback-fieldlabel checkbox">
115 <label>
116 <input id="screenshot-checkbox" type="checkbox">
117 <span id="screenshot-label-current"
118 i18n-content="current-screenshot"></span>
119 </label>
120 <if expr="pp_ifdef('chromeos')">
121 <span id="screenshot-label-saved"
122 i18n-content="saved-screenshot" hidden>
123 </span>
124 <a id="screenshot-link-tosaved" href="#"
125 i18n-content="choose-different-screenshot">
126 </a>
127 <a id="screenshot-link-tocurrent" href="#"
128 i18n-content="choose-original-screenshot"
129 hidden>
130 </a>
131 </if>
132 </td>
133 </tr>
134 </table>
135 </td>
136 </tr>
137 <tr>
138 <td>
139 <if expr="pp_ifdef('chromeos')">
140 <div id="saved-screenshots" class="thumbnail-list"
141 hidden></div>
142 </if>
143 <div id="current-screenshots" class="thumbnail-list">
144 </div>
145 </td>
146 </tr>
147 </table>
148 </td>
149 </tr>
150 <tr>
151 <td>
152 <div id="privacy-note" i18n-values=".innerHTML:privacy-note">
153 </div>
154 <div id="buttons-pane">
155 <!-- Buttons -->
156 <input id="send-report-button" type="submit"
157 class="feedback-button"
158 i18n-values="value:send-report">
159 <input id="cancel-button" type="submit"
160 class="feedback-button" i18n-values="value:cancel">
161 </div>
162 </td>
163 </tr>
164 </tbody>
165 </table>
166 </div>
167 </div> 41 </div>
168 </div> 42 </div>
43 <!-- System Information -->
44 <div class="feedback-fieldlabel checkbox">
45 <label>
46 <input id="sys-info-checkbox" type="checkbox"
47 checked>
48 <span id="sysinfo-label">
49 <a id="sysinfo-url" href="#"
50 i18n-content="sysinfo"></a>
51 </span>
52 </label>
53 </div>
54 </if>
55 <!-- Screenshot -->
56 <div id="screenshot-row">
57 <div class="feedback-fieldlabel checkbox">
58 <label>
59 <input id="screenshot-checkbox" type="checkbox">
60 <span id="screenshot-label-current"
61 i18n-content="current-screenshot"></span>
62 <if expr="pp_ifdef('chromeos')">
63 <span id="screenshot-label-saved"
64 i18n-content="saved-screenshot" hidden></span>
65 </label>
66 <a id="screenshot-link-tosaved" href="#"
Dan Beam 2012/05/16 22:38:14 why not -to-saved and -to-current?
Evan Stade 2012/05/16 23:56:24 ask the original author
Dan Beam 2012/05/17 05:09:05 I thought I was asking the current owner, ;)
Evan Stade 2012/05/17 16:38:57 false, if I "owned" everything I'd ever touched I
67 i18n-content="choose-different-screenshot">
68 </a>
69 <a id="screenshot-link-tocurrent" href="#"
70 i18n-content="choose-original-screenshot"
Dan Beam 2012/05/16 22:38:14 shouldn't these be 4\s wrapped?
Evan Stade 2012/05/16 23:56:24 Done.
71 hidden>
72 </a>
73 </if>
74 </div>
75 <if expr="pp_ifdef('chromeos')">
76 <div id="saved-screenshots" class="thumbnail-list"
77 hidden></div>
78 </if>
79 <div id="current-screenshots" class="thumbnail-list">
80 </div>
81 <div id="privacy-note" i18n-values=".innerHTML:privacy-note"></div>
82 <div id="buttons-pane">
83 <!-- Buttons -->
84 <input id="send-report-button" type="submit"
85 class="feedback-button"
86 i18n-values="value:send-report">
87 <input id="cancel-button" type="submit"
88 class="feedback-button" i18n-values="value:cancel">
89 </div>
169 </div> 90 </div>
170 </div> 91 <script src="chrome://resources/js/i18n_template2.js"></script>
171 <script src="chrome://resources/js/i18n_template.js"></script>
172 <script src="chrome://resources/js/i18n_process.js"></script>
173 </body> 92 </body>
174 </html> 93 </html>
OLDNEW
« chrome/browser/resources/feedback.css ('K') | « chrome/browser/resources/feedback.css ('k') | chrome/browser/resources/feedback.js » ('j') | chrome/browser/resources/feedback.js » ('J')

Powered by Google App Engine
This is Rietveld 408576698