Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10393)

Unified Diff: chrome/common/safe_browsing/csd.proto

Issue 10382113: Add SafeBrowsing support for checking downloaded zip files that contain executables. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Minor cleanup Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/safe_browsing/csd.proto
diff --git a/chrome/common/safe_browsing/csd.proto b/chrome/common/safe_browsing/csd.proto
index e8fbc8096cdb9acbe1d931d7aa051cb46a006051..c21a7c7ea9ad698b8987f7d1469fca71068d2284 100644
--- a/chrome/common/safe_browsing/csd.proto
+++ b/chrome/common/safe_browsing/csd.proto
@@ -168,6 +168,8 @@ message ClientDownloadRequest {
WIN_EXECUTABLE = 0; // Currently all .exe, .cab and .msi files.
CHROME_EXTENSION = 1; // .crx files.
ANDROID_APK = 2; // .apk files.
+ // .zip files containing one of the above executable types.
+ ZIPPED_WIN_EXECUTABLE = 3;
mattm 2012/05/11 22:42:06 APK isn't a win executable?
Brian Ryner 2012/05/11 23:09:41 It's not, no. Are you suggesting that we don't pi
mattm 2012/05/11 23:12:32 Oh just that "zipped win executable" contains "one
Brian Ryner 2012/05/12 00:06:59 Sounds reasonable, renamed the enum.
}
optional DownloadType download_type = 10 [default = WIN_EXECUTABLE];
}

Powered by Google App Engine
This is Rietveld 408576698