Added support for Google Drive's external app document type

chrome/browser/chromeos/gdata/gdata_parser.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_GDATA_GDATA_PARSER_H_
 #define CHROME_BROWSER_CHROMEOS_GDATA_GDATA_PARSER_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 263 matching lines @@
 };
 
 // Document feed entry.
 class DocumentEntry : public FeedEntry {
  public:
   enum EntryKind {
     UNKNOWN       = 0x000000,
     // Special entries.
     ITEM          = 0x001001,
     SITE          = 0x001002,
-    // Hosted documents.
-    DOCUMENT      = 0x002001,
-    SPREADSHEET   = 0x002002,
-    PRESENTATION  = 0x002003,
-    DRAWING       = 0x002004,
-    TABLE         = 0x002005,
+    // Hosted Google document.
+    DOCUMENT      = 0x002101,
+    SPREADSHEET   = 0x002102,
+    PRESENTATION  = 0x002103,
+    DRAWING       = 0x002104,
+    TABLE         = 0x002105,
+    // Hosted external application document.
+    EXTERNAL_APP  = 0x002201,
     // Folders, collections.
     FOLDER        = 0x004001,
     // Regular files.
     FILE          = 0x008001,
     PDF           = 0x008002,
   };
   virtual ~DocumentEntry();
 
   // Creates document entry from parsed JSON Value.  You should call
   // this instead of instantiating JSONValueConverter by yourself
@@ skipping 63 matching lines @@
 
 // Text version of document entry kind. Returns an empty string for
   // unknown entry kind.
   std::string GetEntryKindText() const;
 
   // Returns preferred file extension for hosted documents. If entry is not
   // a hosted document, this call returns an empty string.
   std::string GetHostedDocumentExtension() const;
 
   // True if document entry is remotely hosted.
-  bool is_hosted_document() const { return (kind_ & 0x002000) != 0; }
+  bool is_hosted_document() const { return (kind_ & 0x002000) == 0x002000; }
+  // True if document entry hosted by Google Documents.
+  bool is_google_document() const { return (kind_ & 0x002100) == 0x002100; }
+  // True if document entry is hosted by an external application.
+  bool is_external_app() const { return (kind_ & 0x002200) == 0x002200; }

[satorux1, 2012/05/16 20:07:09]

maybe is_external_app_document() to be more descriptive?

[zel, 2012/05/16 20:56:14]

Done.

   // True if document entry is a folder (collection).
   bool is_folder() const { return (kind_ & 0x004000) != 0; }
   // True if document entry is regular file.
   bool is_file() const { return (kind_ & 0x008000) != 0; }
   // True if document entry can't be mapped to the file system.
   bool is_special() const {
     return !is_file() && !is_folder() && !is_hosted_document();
   }
 
  private:
@@ skipping 212 matching lines @@
   int largest_changestamp_;
   ScopedVector<InstalledApp> installed_apps_;
 
   DISALLOW_COPY_AND_ASSIGN(AccountMetadataFeed);
 };
 
 
 }  // namespace gdata
 
 #endif  // CHROME_BROWSER_CHROMEOS_GDATA_GDATA_PARSER_H_