[Chromoting] The Windows IT2Me host gets any new text items it finds on the clipboard.

remoting/host/event_executor_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/event_executor.h"
 
 #include <windows.h>
 
 #include "base/bind.h"
 #include "base/compiler_specific.h"
 #include "base/message_loop.h"
+#include "base/message_loop_proxy.h"
 #include "remoting/host/capturer.h"
 #include "remoting/host/clipboard.h"
 #include "remoting/proto/event.pb.h"
 #include "ui/base/keycodes/keyboard_codes.h"
 
 namespace remoting {
 
 namespace {
 
 using protocol::ClipboardEvent;
 using protocol::KeyEvent;
 using protocol::MouseEvent;
 
 // USB to XKB keycode map table.
 #define USB_KEYMAP(usb, xkb, win, mac) {usb, win}
 #include "remoting/host/usb_keycode_map.h"
 #undef USB_KEYMAP
 
 // A class to generate events on Windows.
 class EventExecutorWin : public EventExecutor {
  public:
-  EventExecutorWin(MessageLoop* message_loop, Capturer* capturer);
+  EventExecutorWin(MessageLoop* message_loop,
+                   base::MessageLoopProxy* ui_loop,
+                   Capturer* capturer);
   virtual ~EventExecutorWin() {}
 
   // ClipboardStub interface.
   virtual void InjectClipboardEvent(const ClipboardEvent& event) OVERRIDE;
 
   // InputStub interface.
   virtual void InjectKeyEvent(const KeyEvent& event) OVERRIDE;
   virtual void InjectMouseEvent(const MouseEvent& event) OVERRIDE;
 
   // EventExecutor interface.
   virtual void OnSessionStarted() OVERRIDE;
   virtual void OnSessionFinished() OVERRIDE;
 
  private:
   HKL GetForegroundKeyboardLayout();
+  void HandleClipboard(const ClipboardEvent& event);
   void HandleKey(const KeyEvent& event);
   void HandleMouse(const MouseEvent& event);
   void HandleSessionStarted();
   void HandleSessionFinished();
 
   MessageLoop* message_loop_;
+  base::MessageLoopProxy* ui_loop_;
   Capturer* capturer_;
   scoped_ptr<Clipboard> clipboard_;
 
   DISALLOW_COPY_AND_ASSIGN(EventExecutorWin);
 };
 
 EventExecutorWin::EventExecutorWin(MessageLoop* message_loop,
+                                   base::MessageLoopProxy* ui_loop,
                                    Capturer* capturer)
     : message_loop_(message_loop),
+      ui_loop_(ui_loop),
       capturer_(capturer),
       clipboard_(Clipboard::Create()) {
 }
 
 void EventExecutorWin::InjectClipboardEvent(const ClipboardEvent& event) {
-  if (MessageLoop::current() != message_loop_) {
-    message_loop_->PostTask(
-        FROM_HERE,
-        base::Bind(&EventExecutorWin::InjectClipboardEvent,
-                   base::Unretained(this),
-                   event));
-    return;
-  }
-
-  clipboard_->InjectClipboardEvent(event);
+  ui_loop_->PostTask(

[Wez, 2012/05/15 23:46:19]

You could test if (!ui_loop_->BelongsToCurrentThread()) here to avoid the need
for a separate HandleClipboard() member.

[simonmorris, 2012/05/16 00:41:33]

Done. (I liked the consistency of having a separate HandleXXX, but I'm in the
minority).

+      FROM_HERE,
+      base::Bind(&EventExecutorWin::HandleClipboard,
+                 base::Unretained(this),

[Wez, 2012/05/15 23:46:19]

Doesn't this mean we risk a crash if a clipboard event comes in just as we're
tearing down the EventExecutor?

[simonmorris, 2012/05/16 00:41:33]

No more than with InjectKeyEvent() and InjectMouseEvent(). The
DesktopEnvironment and EventExecutor outlive the host, so I don't think there's
a problem. 

+                 event));
 }
 
 void EventExecutorWin::InjectKeyEvent(const KeyEvent& event) {
   if (MessageLoop::current() != message_loop_) {
     message_loop_->PostTask(
         FROM_HERE,
         base::Bind(&EventExecutorWin::InjectKeyEvent, base::Unretained(this),
                    event));
     return;
   }
 
   HandleKey(event);
 }
 
 void EventExecutorWin::InjectMouseEvent(const MouseEvent& event) {
   if (MessageLoop::current() != message_loop_) {
     message_loop_->PostTask(
         FROM_HERE,
         base::Bind(&EventExecutorWin::InjectMouseEvent, base::Unretained(this),
                    event));
     return;
   }
 
   HandleMouse(event);
 }
 
 void EventExecutorWin::OnSessionStarted() {
-  if (MessageLoop::current() != message_loop_) {
-    message_loop_->PostTask(
-        FROM_HERE,
-        base::Bind(&EventExecutorWin::OnSessionStarted,
-                   base::Unretained(this)));
-    return;
-  }
-
-  HandleSessionStarted();
+  ui_loop_->PostTask(

[Wez, 2012/05/15 23:46:19]

As above, with an if (BelongsToCurrentThread()) test, couldn't you get rid of
the separate HandleSessionStarted()?

[simonmorris, 2012/05/16 00:41:33]

Done.

+      FROM_HERE,
+      base::Bind(&EventExecutorWin::HandleSessionStarted,
+                 base::Unretained(this)));
 }
 
 void EventExecutorWin::OnSessionFinished() {
-  if (MessageLoop::current() != message_loop_) {
-    message_loop_->PostTask(
-        FROM_HERE,
-        base::Bind(&EventExecutorWin::OnSessionFinished,
-                   base::Unretained(this)));
-    return;
-  }
-
-  HandleSessionFinished();
+  ui_loop_->PostTask(
+      FROM_HERE,
+      base::Bind(&EventExecutorWin::HandleSessionFinished,
+                 base::Unretained(this)));
 }
 
 HKL EventExecutorWin::GetForegroundKeyboardLayout() {
   HKL layout = 0;
 
   // Can return NULL if a window is losing focus.
   HWND foreground = GetForegroundWindow();
   if (foreground) {
     // Can return 0 if the window no longer exists.
     DWORD thread_id = GetWindowThreadProcessId(foreground, 0);
     if (thread_id) {
       // Can return 0 if the thread no longer exists, or if we're
       // running on Windows Vista and the window is a command-prompt.
       layout = GetKeyboardLayout(thread_id);
     }
   }
 
   // If we couldn't determine a layout then use the system default.
   if (!layout) {
     SystemParametersInfo(SPI_GETDEFAULTINPUTLANG, 0, &layout, 0);
   }
 
   return layout;
 }
 
+void EventExecutorWin::HandleClipboard(const ClipboardEvent& event) {
+  clipboard_->InjectClipboardEvent(event);
+}
+
 void EventExecutorWin::HandleKey(const KeyEvent& event) {
   // HostEventDispatcher should filter events missing the pressed field.
   DCHECK(event.has_pressed());
 
   // Reset the system idle suspend timeout.
   SetThreadExecutionState(ES_SYSTEM_REQUIRED);
 
   // The mapping between scancodes and VKEY values depends on the foreground
   // window's current keyboard layout.
   HKL layout = GetForegroundKeyboardLayout();
@@ skipping 119 matching lines @@
 void EventExecutorWin::HandleSessionStarted() {
   clipboard_->Start();
 }
 
 void EventExecutorWin::HandleSessionFinished() {
   clipboard_->Stop();
 }
 
 }  // namespace
 
-scoped_ptr<EventExecutor> EventExecutor::Create(
-    MessageLoop* message_loop, Capturer* capturer) {
+scoped_ptr<EventExecutor> EventExecutor::Create(MessageLoop* message_loop,
+                                                base::MessageLoopProxy* ui_loop,
+                                                Capturer* capturer) {
   return scoped_ptr<EventExecutor>(
-      new EventExecutorWin(message_loop, capturer));
+      new EventExecutorWin(message_loop, ui_loop, capturer));
 }
 
 }  // namespace remoting