Refactor UI "badge" (page action) logic into a BadgeController interface.

chrome/browser/extensions/badge_controller.h

Index: chrome/browser/extensions/badge_controller.h
diff --git a/chrome/browser/extensions/badge_controller.h b/chrome/browser/extensions/badge_controller.h
new file mode 100644
index 0000000000000000000000000000000000000000..5bc87c425a538dd312fd0d6aae57430589eba64e
--- /dev/null
+++ b/chrome/browser/extensions/badge_controller.h
@@ -0,0 +1,54 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_BADGE_CONTROLLER_H_
+#define CHROME_BROWSER_EXTENSIONS_BADGE_CONTROLLER_H_
+#pragma once
+
+#include <string>
+#include <vector>
+
+#include "base/memory/scoped_ptr.h"
+#include "chrome/browser/extensions/badge_decoration.h"
+
+class ExtensionAction;
+
+namespace extensions {
+
+// Controller of the "badges" (aka "page actions") in the UI.

[Evan Stade, 2012/05/11 21:52:08]

confused about the terminology. I thought "badge" referred to the text that you
can add to a browser action, e.g. the number of unread gmail messages.

[Matt Perry, 2012/05/11 22:01:17]

Good point. This should be named ExtensionActionController.

[not at google - send to devlin, 2012/05/14 03:59:01]

Cool. "Badge" was an attempt to make an agnostic name wrt what these are about
to become, "script badges", so I think ExtensionActionController would be
likewise misleading.

How about "PageBoxController"? This is what that area is / will be called I
think.

[Matt Perry, 2012/05/14 18:48:57]

I'm not a fan of PageBox. The generic name for Page/Browser Actions is
ExtensionAction. What's wrong with ExtensionActionController?

[not at google - send to devlin, 2012/05/15 01:23:56]

As discussed on IRC, made it ActionBoxController.

+class BadgeController {
+ public:
+  // Data about a UI badge.
+  struct Data {
+    // The type of decoration that should be applied to the badge.
+    badge_decoration::Decoration decoration;
+
+    // The ExtensionAction that corresponds to the badge.
+    ExtensionAction* action;
+  };
+
+  typedef std::vector<Data> DataList;
+
+  // The reaction that the UI should take after executing |OnClicked|.
+  enum Reaction {

[Matt Perry, 2012/05/11 21:15:12]

Just "Action" ?

[not at google - send to devlin, 2012/05/14 03:59:01]

Done.

+    NONE,
+    SHOW_POPUP,
+    SHOW_CONTEXT_MENU,
+  };
+
+  virtual ~BadgeController() {}
+
+  // Gets the badge data for all extensions.
+  virtual scoped_ptr<DataList> GetAllBadgeData() = 0;
+
+  // Notifies this that the badge for an extension has been clicked with some
+  // mouse button (1 for left, 2 for middle, and 3 for right click), and
+  // returns the action that should be taken in response (if any).
+  virtual Reaction OnClicked(const std::string& extension_id,
+                             int button_type) = 0;
+};
+
+}  // namespace extensions
+
+#endif  // CHROME_BROWSER_EXTENSIONS_BADGE_CONTROLLER_H_