Aura/ash split: Don't use X11 window borders.

ui/base/x/x11_atom_cache.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ui/base/x/x11_atom_cache.h"
+
+#include <X11/Xatom.h>
+
+#include "base/message_pump_x.h"
+
+namespace {
+
+// A list of atoms that we'll intern on host creation to save roundtrips to the
+// X11 server. Must be kept in sync with AtomCache::AtomName

[Daniel Erat, 2012/05/15 20:59:41]

This makes me nervous (especially combined with non-alphabetical ordering of the
entries in the list).  It's more code, but mind making this be an array of
structs containing (enum, string) pairs and loading everything into a map
instead?  See e.g.
http://git.chromium.org/gitweb/?p=chromiumos/platform/window_manager.git;a=bl...
and
http://git.chromium.org/gitweb/?p=chromiumos/platform/window_manager.git;a=bl....

[Elliot Glaysher, 2012/05/15 21:56:32]

Done.

+const char* kAtomList[] = {
+  "WM_DELETE_WINDOW",
+  "_NET_WM_MOVERESIZE",
+  "_NET_WM_PING",
+  "_NET_WM_PID",
+  "WM_S0",
+  "_MOTIF_WM_HINTS"
+};
+
+}  // namespace
+
+namespace ui {
+
+X11AtomCache* X11AtomCache::GetInstance() {
+  return Singleton<X11AtomCache>::get();
+}
+
+::Atom X11AtomCache::GetAtom(AtomName name) const {
+  return cached_atoms_[name];
+}
+
+X11AtomCache::X11AtomCache() {
+  // Grab all the atoms we need now to minimize roundtrips to the X11 server.
+  XInternAtoms(base::MessagePumpX::GetDefaultXDisplay(),
+               const_cast<char**>(kAtomList), ATOM_COUNT, False,
+               cached_atoms_);
+}
+
+X11AtomCache::~X11AtomCache() {}
+
+}  // namespace ui
+
+