Aura/ash split: Don't use X11 window borders.

ui/aura/event.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/aura/event.h"
 
 #if defined(USE_X11)
 #include <X11/Xlib.h>
 #endif
 
@@ skipping 82 matching lines @@
 }
 
 LocatedEvent::~LocatedEvent() {
 }
 
 LocatedEvent::LocatedEvent(const base::NativeEvent& native_event)
     : Event(native_event,
             ui::EventTypeFromNative(native_event),
             ui::EventFlagsFromNative(native_event)),
       location_(ui::EventLocationFromNative(native_event)),
-      root_location_(location_) {
+      root_location_(ui::EventRootLocationFromNative(native_event)) {

[sadrul, 2012/05/10 13:34:10]

This might be tricky; I think 'root_location_' is meant to be in the
RootWindow's coordinate system, and 'location_' is meant to be in a Window's
coordinate system. Changing the meaning of 'root_location_' to be in the
system's coordinate system may introduce bugs. It looks like you need the
system-coordinate only in RootWindowHostLinux::DispatchHostWindowDragMovement.
Would it make sense to keep the meaning of root_location_ unchanged, and extract
the desired location in RWHL::DispatchHostWindowDragMovement from
event->native_event()?

 }
 
 LocatedEvent::LocatedEvent(const LocatedEvent& model,
                            Window* source,
                            Window* target)
     : Event(model),
       location_(model.location_),
       root_location_(model.root_location_) {
   if (target && target != source)
     Window::ConvertPointToWindow(source, target, &location_);
 }
 
 LocatedEvent::LocatedEvent(ui::EventType type,
                            const gfx::Point& location,
                            const gfx::Point& root_location,
                            int flags)
     : Event(type, flags),
       location_(location),
       root_location_(location) {
 }
 
 void LocatedEvent::UpdateForRootTransform(const ui::Transform& root_transform) {
   // Transform has to be done at root level.
-  DCHECK_EQ(root_location_.x(), location_.x());
-  DCHECK_EQ(root_location_.y(), location_.y());
-  gfx::Point3f p(location_);
-  root_transform.TransformPointReverse(p);
-  root_location_ = location_ = p.AsPoint();
+  if (!root_transform.matrix().isIdentity()) {
+    // TODO(oshima): This isn't correct in any environment that isn't ash. It
+    // assumes that the all locations are root relative which is only true in
+    // ash. This is only true in real desktop environments when our window is
+    // sitting at the root origin.
+    DCHECK_EQ(root_location_.x(), location_.x());
+    DCHECK_EQ(root_location_.y(), location_.y());
+    gfx::Point3f p(location_);
+    root_transform.TransformPointReverse(p);
+    root_location_ = location_ = p.AsPoint();
+  }
 }
 
 MouseEvent::MouseEvent(const base::NativeEvent& native_event)
     : LocatedEvent(native_event) {
   if (type() == ui::ET_MOUSE_PRESSED)
     SetClickCount(GetRepeatCount(*this));
 }
 
 MouseEvent::MouseEvent(const MouseEvent& model, Window* source, Window* target)
     : LocatedEvent(model, source, target) {
@@ skipping 321 matching lines @@
 int GestureEvent::GetLowestTouchId() const {
   if (touch_ids_bitfield_ == 0)
     return -1;
   int i = -1;
   // Find the index of the least significant 1 bit
   while (!(1 << ++i & touch_ids_bitfield_));
   return i;
 }
 
 }  // namespace aura