Refactoring AutocompleteActionPredictor Database.

chrome/browser/predictors/predictor_table_base.h

Index: chrome/browser/predictors/predictor_table_base.h
diff --git a/chrome/browser/predictors/predictor_table_base.h b/chrome/browser/predictors/predictor_table_base.h
new file mode 100644
index 0000000000000000000000000000000000000000..7f52d0f3243273767741853e8eaaf96f0cc8a5f1
--- /dev/null
+++ b/chrome/browser/predictors/predictor_table_base.h
@@ -0,0 +1,47 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PREDICTORS_PREDICTOR_TABLE_BASE_H_
+#define CHROME_BROWSER_PREDICTORS_PREDICTOR_TABLE_BASE_H_
+#pragma once
+
+#include "base/memory/ref_counted.h"
+#include "base/synchronization/cancellation_flag.h"
+
+namespace sql {
+class Connection;
+}
+
+namespace predictors {
+
+// Base class for all tables in the PredictorDatabase.
+//
+// Refcounted as it is created and destroyed in the UI thread but all database
+// related functions need to happen in the database thread.
+class PredictorTableBase

[dominich, 2012/05/08 20:35:28]

consider just PredictorTable. It's cleaner.

[Shishir, 2012/05/08 21:49:03]

There is precedence for both kind of naming in the codebase. I like this because
it seems more readable. If you feel strongly about this, I will change it.

+    : public base::RefCountedThreadSafe<PredictorTableBase> {
+ protected:
+  PredictorTableBase();
+  virtual ~PredictorTableBase();
+
+  // DB thread functions.
+  virtual void CreateTableIfNonExistent() = 0;
+  virtual void LogDatabaseStats() = 0;
+  void Initialize(sql::Connection* db);
+  sql::Connection* DB();
+  void ResetDB();
+
+  base::CancellationFlag cancelled_;
+
+ private:
+  friend class base::RefCountedThreadSafe<PredictorTableBase>;
+
+  sql::Connection* db_;
+
+  DISALLOW_COPY_AND_ASSIGN(PredictorTableBase);
+};
+
+}  // namespace predictors
+
+#endif  // CHROME_BROWSER_PREDICTORS_PREDICTOR_TABLE_BASE_H_