Verify that xmpp_login specified in the config matches auth token.

remoting/jingle_glue/xmpp_signal_strategy.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/jingle_glue/xmpp_signal_strategy.h"
 
+#include "base/bind.h"
 #include "base/logging.h"
+#include "base/string_util.h"
 #include "jingle/notifier/base/gaia_token_pre_xmpp_auth.h"
 #include "remoting/jingle_glue/jingle_thread.h"
 #include "remoting/jingle_glue/xmpp_socket_adapter.h"
 #include "third_party/libjingle/source/talk/base/asyncsocket.h"
 #include "third_party/libjingle/source/talk/xmpp/prexmppauth.h"
 #include "third_party/libjingle/source/talk/xmpp/saslcookiemechanism.h"
 
 namespace {
 
 const char kDefaultResourceName[] = "chromoting";
 
 // Use 58 seconds keep-alive interval, in case routers terminate
 // connections that are idle for more than a minute.
 const int kKeepAliveIntervalSeconds = 50;
 
+void DisconnectXmppClient(buzz::XmppClient* client) {
+  client->Disconnect();
+}
+
 }  // namespace
 
 namespace remoting {
 
 XmppSignalStrategy::XmppSignalStrategy(JingleThread* jingle_thread,
                                        const std::string& username,
                                        const std::string& auth_token,
                                        const std::string& auth_token_service)
    : thread_(jingle_thread),
      username_(username),
      auth_token_(auth_token),
      auth_token_service_(auth_token_service),
      resource_name_(kDefaultResourceName),
      xmpp_client_(NULL),
-     state_(DISCONNECTED) {
+     state_(DISCONNECTED),
+     error_(NO_ERROR) {
 }
 
 XmppSignalStrategy::~XmppSignalStrategy() {
-  DCHECK_EQ(listeners_.size(), 0U);
   Disconnect();
 }
 
 void XmppSignalStrategy::Connect() {
   DCHECK(CalledOnValidThread());
 
   // Disconnect first if we are currently connected.
   Disconnect();
 
   buzz::XmppClientSettings settings;
@@ skipping 30 matching lines @@
     // in response to Disconnect() call above.
     DCHECK(xmpp_client_ == NULL);
   }
 }
 
 SignalStrategy::State XmppSignalStrategy::GetState() const {
   DCHECK(CalledOnValidThread());
   return state_;
 }
 
+SignalStrategy::Error XmppSignalStrategy::GetError() const {
+  DCHECK(CalledOnValidThread());
+  return error_;
+}
+
 std::string XmppSignalStrategy::GetLocalJid() const {
   DCHECK(CalledOnValidThread());
   return xmpp_client_->jid().Str();
 }
 
 void XmppSignalStrategy::AddListener(Listener* listener) {
   DCHECK(CalledOnValidThread());
   listeners_.AddObserver(listener);
 }
 
@@ skipping 45 matching lines @@
 }
 
 void XmppSignalStrategy::SetResourceName(const std::string &resource_name) {
   DCHECK(CalledOnValidThread());
   resource_name_ = resource_name;
 }
 
 void XmppSignalStrategy::OnConnectionStateChanged(
     buzz::XmppEngine::State state) {
   DCHECK(CalledOnValidThread());
+
   if (state == buzz::XmppEngine::STATE_OPEN) {
+    // Verify that the JID that we've received doesn't match the

[simonmorris, 2012/05/11 19:57:25]

"doesn't match" -> "matches".

[Sergey Ulanov, 2012/05/11 20:48:05]

Done.

+    // username that we have. That probably means that the OAuth token

[simonmorris, 2012/05/11 19:57:25]

"That probably means" -> "If it doesn't, then... was probably issued".

[Sergey Ulanov, 2012/05/11 20:48:05]

Done.

+    // was issued for a different account, so we treat is a an auth
+    // error.
+    if (!StartsWithASCII(GetLocalJid(), username_, false)) {

[simonmorris, 2012/05/11 19:57:25]

Other cases may be worth considering. I'll follow up by email.

+      LOG(ERROR) << "Received JID that is different from the expected value.";
+      error_ = AUTHENTICATION_FAILED;
+      xmpp_client_->SignalStateChange.disconnect(this);
+      MessageLoop::current()->PostTask(
+          FROM_HERE, base::Bind(&DisconnectXmppClient, xmpp_client_));
+      xmpp_client_ = NULL;
+      SetState(DISCONNECTED);
+      return;
+    }
+
     keep_alive_timer_.Start(
         FROM_HERE, base::TimeDelta::FromSeconds(kKeepAliveIntervalSeconds),
         this, &XmppSignalStrategy::SendKeepAlive);
     SetState(CONNECTED);
   } else if (state == buzz::XmppEngine::STATE_CLOSED) {
     // Make sure we dump errors to the log.
     int subcode;
     buzz::XmppEngine::Error error = xmpp_client_->GetError(&subcode);
     LOG(INFO) << "XMPP connection was closed: error=" << error
               << ", subcode=" << subcode;
 
     keep_alive_timer_.Stop();
 
     // Client is destroyed by the TaskRunner after the client is
     // closed. Reset the pointer so we don't try to use it later.
     xmpp_client_ = NULL;
+
+    switch (error) {
+      case buzz::XmppEngine::ERROR_UNAUTHORIZED:
+      case buzz::XmppEngine::ERROR_AUTH:
+      case buzz::XmppEngine::ERROR_MISSING_USERNAME:
+        error_ = AUTHENTICATION_FAILED;
+        break;
+
+      default:
+        error_ = NETWORK_ERROR;
+    }
+
     SetState(DISCONNECTED);
   }
 }
 
 void XmppSignalStrategy::SetState(State new_state) {
   if (state_ != new_state) {
     state_ = new_state;
     FOR_EACH_OBSERVER(Listener, listeners_,
                       OnSignalStrategyStateChange(new_state));
   }
@@ skipping 10 matching lines @@
   std::string mechanism = notifier::GaiaTokenPreXmppAuth::kDefaultAuthMechanism;
   if (settings.token_service() == "oauth2") {
     mechanism = "X-OAUTH2";
   }
 
   return new notifier::GaiaTokenPreXmppAuth(
       jid.Str(), settings.auth_cookie(), settings.token_service(), mechanism);
 }
 
 }  // namespace remoting