Browser Plugin: Removed BrowserPluginWebContentsObserver (to be replaced by rewritten BrowserPlugi…

content/common/view_messages.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // IPC messages for page rendering.
 // Multiply-included message file, hence no include guard.
 
 #include "base/process.h"
 #include "base/shared_memory.h"
 #include "content/common/content_export.h"
@@ skipping 10 matching lines @@
 #include "content/public/common/renderer_preferences.h"
 #include "content/public/common/selected_file_info.h"
 #include "content/public/common/stop_find_action.h"
 #include "content/public/common/webkit_param_traits.h"
 #include "content/public/common/window_container_type.h"
 #include "ipc/ipc_channel_handle.h"
 #include "ipc/ipc_message_macros.h"
 #include "ipc/ipc_platform_file.h"
 #include "media/base/channel_layout.h"
 #include "media/base/media_log_event.h"
+#include "ppapi/c/pp_instance.h"

[Charlie Reis, 2012/05/11 17:41:03]

I don't see where you're using this.

[Fady Samuel, 2012/05/11 22:03:34]

Done.

 #include "third_party/skia/include/core/SkBitmap.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebCompositionUnderline.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebInputEvent.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebFindOptions.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebMediaPlayerAction.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebPluginAction.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebPopupType.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebScreenInfo.h"
 #include "ui/base/ime/text_input_type.h"
 #include "ui/base/javascript_message_type.h"
@@ skipping 602 matching lines @@
   IPC_STRUCT_MEMBER(bool, swapped_out)
 
   // The initial page ID to use for this view, which must be larger than any
   // existing navigation that might be loaded in the view.  Page IDs are unique
   // to a view and are only updated by the renderer after this initial value.
   IPC_STRUCT_MEMBER(int32, next_page_id)
 
   // The properties of the screen associated with the view.
   IPC_STRUCT_MEMBER(WebKit::WebScreenInfo, screen_info)
 
-  // Indicates whether this newly created RenderView will be hosted by another
-  // RenderView.
-  IPC_STRUCT_MEMBER(bool, guest)
+  // The process id of the RenderProcessHost of the embedder of this view if it

[Charlie Reis, 2012/05/11 17:41:03]

nit: id -> ID

[Fady Samuel, 2012/05/11 22:03:34]

Done.

+  // has one.
+  IPC_STRUCT_MEMBER(int32, embedder_process_id)
+
+  // The routing ID of the embedder of this view if it has one.
+  // The process ID + routing ID uniquely identify the RenderViewHost

[Charlie Reis, 2012/05/11 17:41:03]

Please be specific about embedder_process_id and embedder_routing_id, since
"process ID + routing ID" refer to the current RVH, not the embedder.

[Fady Samuel, 2012/05/11 22:03:34]

Done.

+  // of the embedder.
+  IPC_STRUCT_MEMBER(int32, embedder_routing_id)
 
   // The accessibility mode of the renderer.
   IPC_STRUCT_MEMBER(AccessibilityMode, accessibility_mode)
 IPC_STRUCT_END()
 
 // Messages sent from the browser to the renderer.
 
 // Sent to the RenderView when a new tab is swapped into an existing
 // tab and the histories need to be merged. The existing tab has a history of
 // |merged_history_length| which precedes the history of the new tab. All
@@ skipping 1362 matching lines @@
                     int  /* automation_id */)
 
 // Sent to the browser when the renderer detects it is blocked on a pepper
 // plugin message for too long. This is also sent when it becomes unhung
 // (according to the value of is_hung). The browser can give the user the
 // option of killing the plugin.
 IPC_MESSAGE_ROUTED3(ViewHostMsg_PepperPluginHung,
                     int /* plugin_child_id */,
                     FilePath /* path */,
                     bool /* is_hung */)