Browser Plugin: Removed BrowserPluginWebContentsObserver (to be replaced by rewritten BrowserPlugi…

content/browser/renderer_host/render_view_host_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 211 matching lines @@
   virtual void ToggleSpeechInput() OVERRIDE;
   virtual void UpdateWebkitPreferences(const WebPreferences& prefs) OVERRIDE;
 
   void set_delegate(RenderViewHostDelegate* d) {
     CHECK(d);  // http://crbug.com/82827
     delegate_ = d;
   }
 
   // Set up the RenderView child process. Virtual because it is overridden by
   // TestRenderViewHost. If the |frame_name| parameter is non-empty, it is used
-  // as the name of the new top-level frame.  The |opener_route_id| parameter
-  // indicates which RenderView created this (MSG_ROUTING_NONE if none). If
-  // |max_page_id| is larger than -1, the RenderView is told to start issuing
-  // page IDs at |max_page_id| + 1.
+  // as the name of the new top-level frame.  If |max_page_id| is larger than
+  // -1, the RenderView is told to start issuing page IDs at |max_page_id| + 1.
+  // If this RenderView is a guest, the embedder's process id and routing ID
+  // is also passed in so that the RenderView's process can establish a channel
+  // with its embedder if it's not already established.
+  // The |opener_route_id| parameter indicates which RenderView created this
+  // (MSG_ROUTING_NONE if none). If |max_page_id| is larger than -1, the
+  // RenderView is told to start issuing page IDs at |max_page_id| + 1.

[Charlie Reis, 2012/05/11 17:41:03]

Nit: Why move the opener_route_id comment to the end if it's the second
parameter?

[Fady Samuel, 2012/05/11 22:03:34]

Done.

   virtual bool CreateRenderView(const string16& frame_name,
                                 int opener_route_id,
-                                int32 max_page_id);
+                                int32 max_page_id,
+                                int embedder_process_id,
+                                int embedder_routing_id);
 
   base::TerminationStatus render_view_termination_status() const {
     return render_view_termination_status_;
   }
 
   // Sends the given navigation message. Use this rather than sending it
   // yourself since this does the internal bookkeeping described below. This
   // function takes ownership of the provided message pointer.
   //
   // If a cross-site request is in progress, we may be suspended while waiting
@@ skipping 94 matching lines @@
   void LoadStateChanged(const GURL& url,
                         const net::LoadStateWithParam& load_state,
                         uint64 upload_position,
                         uint64 upload_size);
 
   bool SuddenTerminationAllowed() const;
   void set_sudden_termination_allowed(bool enabled) {
     sudden_termination_allowed_ = enabled;
   }
 
-  void set_guest(bool guest) { guest_ = guest; }
-
   // RenderWidgetHost public overrides.
   virtual void Shutdown() OVERRIDE;
   virtual bool IsRenderView() const OVERRIDE;
   virtual bool OnMessageReceived(const IPC::Message& msg) OVERRIDE;
   virtual void GotFocus() OVERRIDE;
   virtual void LostCapture() OVERRIDE;
   virtual void LostMouseLock() OVERRIDE;
   virtual void ForwardMouseEvent(
       const WebKit::WebMouseEvent& mouse_event) OVERRIDE;
   virtual void OnMouseActivate() OVERRIDE;
@@ skipping 188 matching lines @@
   scoped_refptr<SiteInstanceImpl> instance_;
 
   // true if we are currently waiting for a response for drag context
   // information.
   bool waiting_for_drag_context_response_;
 
   // A bitwise OR of bindings types that have been enabled for this RenderView.
   // See BindingsPolicy for details.
   int enabled_bindings_;
 
-  // Indicates whether or not this RenderViewHost refers to a guest RenderView.
-  bool guest_;
-
   // The request_id for the pending cross-site request. Set to -1 if
   // there is a pending request, but we have not yet started the unload
   // for the current page. Set to the request_id value of the pending
   // request once we have gotten the some data for the pending page
   // and thus started the unload process.
   int pending_request_id_;
 
   // Whether we should buffer outgoing Navigate messages rather than sending
   // them.  This will be true when a RenderViewHost is created for a cross-site
   // request, until we hear back from the onbeforeunload handler of the old
@@ skipping 71 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(RenderViewHostImpl);
 };
 
 #if defined(COMPILER_MSVC)
 #pragma warning(pop)
 #endif
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_VIEW_HOST_IMPL_H_