SessionStorageDatabase: Allow writing data into a shallow copy.

SessionStorageDatabase: Allow writing data into a shallow copy.

BUG=104292
TEST=SessionStorageDatabaseTest.{WriteIntoShallowCopy,NamespaceOffsetWriteIntoShallowCopy}

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=136263

[marja, 2012-05-09 12:08:15]

Hi again,

Second thoughts: it seems more reasonable to let the SessionStorageDatabase take
care of making shallow copies deep whenever needed.

This way the upper layer doesn't need to care; it can just deep-copy the memory
maps.

And after a session restore, we wouldn't even know which maps in the database
are deep copes of each other, and reading that information from the db would be
tedious.

ptal

[michaeln, 2012-05-09 21:46:48]

lgtm, sounds like a nice simplification from the callers point of view

https://chromiumcodereview.appspot.com/10378066/diff/1/webkit/dom_storage/ses...
File webkit/dom_storage/session_storage_database.h (right):

https://chromiumcodereview.appspot.com/10378066/diff/1/webkit/dom_storage/ses...
webkit/dom_storage/session_storage_database.h:60: bool DeepCopyArea(int64
namespace_id, const GURL& origin);
looks like this method decl is obsolete now and should be deleted

[marja, 2012-05-10 06:30:04]

Thanks for review!

http://codereview.chromium.org/10378066/diff/1/webkit/dom_storage/session_sto...
File webkit/dom_storage/session_storage_database.h (right):

http://codereview.chromium.org/10378066/diff/1/webkit/dom_storage/session_sto...
webkit/dom_storage/session_storage_database.h:60: bool DeepCopyArea(int64
namespace_id, const GURL& origin);
On 2012/05/09 21:46:48, michaeln wrote:
> looks like this method decl is obsolete now and should be deleted

Done.

[commit-bot: I haz the power, 2012-05-10 06:30:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/marja@chromium.org/10378066/4001