Exit tabbed fullscreen mode on navigation.

chrome/browser/ui/browser.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_BROWSER_H_
 #define CHROME_BROWSER_UI_BROWSER_H_
 #pragma once
 
 #include <map>
 #include <set>
@@ skipping 855 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(BrowserTest, AppIdSwitch);
   FRIEND_TEST_ALL_PREFIXES(FullscreenControllerTest,
                            TabEntersPresentationModeFromWindowed);
   FRIEND_TEST_ALL_PREFIXES(FullscreenExitBubbleControllerTest,
                            DenyExitsFullscreen);
   FRIEND_TEST_ALL_PREFIXES(StartupBrowserCreatorTest, OpenAppShortcutNoPref);
   FRIEND_TEST_ALL_PREFIXES(StartupBrowserCreatorTest,
                            OpenAppShortcutWindowPref);
   FRIEND_TEST_ALL_PREFIXES(StartupBrowserCreatorTest, OpenAppShortcutTabPref);
   FRIEND_TEST_ALL_PREFIXES(StartupBrowserCreatorTest, OpenAppShortcutPanel);
+  FRIEND_TEST_ALL_PREFIXES(FullscreenControllerTest,
+                           TestTabExitsFullscreenOnNavigation);
+  FRIEND_TEST_ALL_PREFIXES(FullscreenControllerTest,
+                           TestTabDoesntExitFullscreenOnSubFrameNavigation);

[scheib, 2012/06/15 16:12:31]

FullscreenControllerTest is already a friend, we shouldn't need line items for
every test. If there's any new use of private Browser members, consider placing
them in helper methods on FullscreenControllerTest. (Often simplifies those
tests for readability and likely get reused in other tests anyway).

[koz (OOO until 15th September), 2012/06/18 02:28:10]

Cool! Done.

 
   // Used to describe why a tab is being detached. This is used by
   // TabDetachedAtImpl.
   enum DetachType {
     // Result of TabDetachedAt.
     DETACH_TYPE_DETACH,
 
     // Result of TabReplacedAt.
     DETACH_TYPE_REPLACE,
 
@@ skipping 575 matching lines @@
   bool window_has_shown_;
 
   // Currently open color chooser. Non-NULL after OpenColorChooser is called and
   // before DidEndColorChooser is called.
   scoped_ptr<content::ColorChooser> color_chooser_;
 
   DISALLOW_COPY_AND_ASSIGN(Browser);
 };
 
 #endif  // CHROME_BROWSER_UI_BROWSER_H_