Broker out PPAPI handle duplication

content/browser/ppapi_plugin_process_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/ppapi_plugin_process_host.h"
 
 #include <string>
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
@@ skipping 189 matching lines @@
 }
 
 void PpapiPluginProcessHost::RequestPluginChannel(Client* client) {
   base::ProcessHandle process_handle;
   int renderer_id;
   client->GetPpapiChannelInfo(&process_handle, &renderer_id);
 
   // We can't send any sync messages from the browser because it might lead to
   // a hang. See the similar code in PluginProcessHost for more description.
   PpapiMsg_CreateChannel* msg = new PpapiMsg_CreateChannel(
-      process_handle, renderer_id, client->OffTheRecord());
+      renderer_id, client->OffTheRecord());
   msg->set_unblock(true);
   if (Send(msg)) {
     sent_requests_.push(client);
   } else {
-    client->OnPpapiChannelOpened(base::kNullProcessHandle,
-                                 IPC::ChannelHandle(), 0);
+    client->OnPpapiChannelOpened(IPC::ChannelHandle(), 0);
   }
 }
 
 void PpapiPluginProcessHost::OnProcessLaunched() {
 }
 
 bool PpapiPluginProcessHost::OnMessageReceived(const IPC::Message& msg) {
   bool handled = true;
   IPC_BEGIN_MESSAGE_MAP(PpapiPluginProcessHost, msg)
     IPC_MESSAGE_HANDLER(PpapiHostMsg_ChannelCreated,
@@ skipping 26 matching lines @@
   // plugin since they have their own channels which will go into the error
   // state at the same time. Instead, we just need to notify any renderers
   // that have requested a connection but have not yet received one.
   CancelRequests();
 }
 
 void PpapiPluginProcessHost::CancelRequests() {
   DVLOG(1) << "PpapiPluginProcessHost" << (is_broker_ ? "[broker]" : "")
            << "CancelRequests()";
   for (size_t i = 0; i < pending_requests_.size(); i++) {
-    pending_requests_[i]->OnPpapiChannelOpened(base::kNullProcessHandle,
-                                               IPC::ChannelHandle(), 0);
+    pending_requests_[i]->OnPpapiChannelOpened(IPC::ChannelHandle(), 0);
   }
   pending_requests_.clear();
 
   while (!sent_requests_.empty()) {
-    sent_requests_.front()->OnPpapiChannelOpened(base::kNullProcessHandle,
-                                                 IPC::ChannelHandle(), 0);
+    sent_requests_.front()->OnPpapiChannelOpened(IPC::ChannelHandle(), 0);
     sent_requests_.pop();
   }
 }
 
 // Called when a new plugin <--> renderer channel has been created.
 void PpapiPluginProcessHost::OnRendererPluginChannelCreated(
     const IPC::ChannelHandle& channel_handle) {
   if (sent_requests_.empty())
     return;
 
   // All requests should be processed FIFO, so the next item in the
   // sent_requests_ queue should be the one that the plugin just created.
   Client* client = sent_requests_.front();
   sent_requests_.pop();
 
-  // Prepare the handle to send to the renderer.
-  base::ProcessHandle plugin_process = process_->GetHandle();
-#if defined(OS_WIN)
-  base::ProcessHandle renderer_process;
-  int renderer_id;
-  client->GetPpapiChannelInfo(&renderer_process, &renderer_id);
-
-  base::ProcessHandle renderers_plugin_handle = NULL;
-  ::DuplicateHandle(::GetCurrentProcess(), plugin_process,
-                    renderer_process, &renderers_plugin_handle,
-                    0, FALSE, DUPLICATE_SAME_ACCESS);
-#elif defined(OS_POSIX)
-  // Don't need to duplicate anything on POSIX since it's just a PID.
-  base::ProcessHandle renderers_plugin_handle = plugin_process;
-#endif
-
-  client->OnPpapiChannelOpened(renderers_plugin_handle, channel_handle,
-                               process_->GetData().id);
+  client->OnPpapiChannelOpened(channel_handle, process_->GetData().id);
 }