Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pylib/gyp/generator/ninja.py

Issue 10378042: Correct the order in which OutputDirectory and IntermediateDirectory are defined. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« pylib/gyp/generator/make.py ('K') | « pylib/gyp/generator/msvs.py ('k') | pylib/gyp/xcode_emulation.py » ('j') | pylib/gyp/xcode_emulation.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/generator/ninja.py
===================================================================
--- pylib/gyp/generator/ninja.py (revision 1364)
+++ pylib/gyp/generator/ninja.py (working copy)
@@ -949,7 +949,7 @@
'export FOO=foo; export BAR="${FOO} bar;'
that exports |env| to the shell."""
export_str = []
- for k in gyp.xcode_emulation.TopologicallySortedEnvVarKeys(env):
+ for k in reversed(gyp.xcode_emulation.TopologicallySortedEnvVarKeys(env)):
export_str.append('export %s=%s;' %
(k, ninja_syntax.escape(gyp.common.EncodePOSIXShellArgument(env[k]))))
return ' '.join(export_str)
« pylib/gyp/generator/make.py ('K') | « pylib/gyp/generator/msvs.py ('k') | pylib/gyp/xcode_emulation.py » ('j') | pylib/gyp/xcode_emulation.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698