Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1175)

Unified Diff: pylib/gyp/generator/make.py

Issue 10378042: Correct the order in which OutputDirectory and IntermediateDirectory are defined. (Closed) Base URL: http://gyp.googlecode.com/svn/trunk/
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pylib/gyp/generator/make.py
===================================================================
--- pylib/gyp/generator/make.py (revision 1364)
+++ pylib/gyp/generator/make.py (working copy)
@@ -1796,7 +1796,7 @@
def WriteXcodeEnv(self, target, env):
- for k in gyp.xcode_emulation.TopologicallySortedEnvVarKeys(env):
+ for k in reversed(gyp.xcode_emulation.TopologicallySortedEnvVarKeys(env)):
Nico 2012/05/11 14:53:44 When refactoring a function (gyp.xcode_emu.TopSort
bradn 2012/05/11 18:57:23 So I had been "correcting" what I had perceived as
# For
# foo := a\ b
# the escaped space does the right thing. For

Powered by Google App Engine
This is Rietveld 408576698