chrome/tools/profiles/generate_profile.cc - Issue 10378009: Get rid of Image::Image(SkBitmap*)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/tools/profiles/generate_profile.cc

Issue 10378009: Get rid of Image::Image(SkBitmap*) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: k Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/tools/profiles/generate_profile.cc

diff --git a/chrome/tools/profiles/generate_profile.cc b/chrome/tools/profiles/generate_profile.cc

index 940b27dac8c85d2ba9f7ece79e18d30345445153..c310879f0f3a89058b390fc19ca18382d009352c 100644

--- a/chrome/tools/profiles/generate_profile.cc

+++ b/chrome/tools/profiles/generate_profile.cc

@@ -181,9 +181,9 @@ void InsertURLBatch(Profile* profile,

if (types & FULL_TEXT)

history_service->SetPageContents(url, ConstructRandomPage());

if (types & TOP_SITES && top_sites) {

- SkBitmap* bitmap = (RandomInt(0, 2) == 0) ? google_bitmap.get() :

- weewar_bitmap.get();

- gfx::Image image(new SkBitmap(*bitmap));

+ const SkBitmap& bitmap = (RandomInt(0, 2) == 0) ? *google_bitmap :

+ *weewar_bitmap;

+ gfx::Image image(bitmap);

top_sites->SetPageThumbnail(url, &image, score);

}