Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(360)

Unified Diff: content/browser/renderer_host/render_widget_host_unittest.cc

Issue 10377158: Move keyboard related methods from RenderViewHostDelegate to a new RenderWidgetHostDelegate (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: now with new files added Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_unittest.cc
diff --git a/content/browser/renderer_host/render_widget_host_unittest.cc b/content/browser/renderer_host/render_widget_host_unittest.cc
index 6f2f08980919139980ea4c38b3890f48312a2b9f..a95b9cc85bc01821ce6ded4e9871988e5f2ac8f6 100644
--- a/content/browser/renderer_host/render_widget_host_unittest.cc
+++ b/content/browser/renderer_host/render_widget_host_unittest.cc
@@ -8,6 +8,7 @@
#include "base/timer.h"
#include "content/browser/browser_thread_impl.h"
#include "content/browser/renderer_host/backing_store.h"
+#include "content/browser/renderer_host/render_widget_host_delegate.h"
#include "content/browser/renderer_host/test_render_view_host.h"
#include "content/common/view_messages.h"
#include "content/port/browser/render_widget_host_view_port.h"
@@ -147,12 +148,23 @@ class TestView : public content::TestRenderWidgetHostView {
DISALLOW_COPY_AND_ASSIGN(TestView);
};
+// MockRenderWidgetHostDelegate --------------------------------------------
+
+class MockRenderWidgetHostDelegate : public content::RenderWidgetHostDelegate {
+ public:
+ MockRenderWidgetHostDelegate() {}
+ virtual ~MockRenderWidgetHostDelegate() {}
+};
+
// MockRenderWidgetHost ----------------------------------------------------
class MockRenderWidgetHost : public RenderWidgetHostImpl {
public:
- MockRenderWidgetHost(content::RenderProcessHost* process, int routing_id)
- : RenderWidgetHostImpl(process, routing_id),
+ MockRenderWidgetHost(
+ content::RenderWidgetHostDelegate* delegate,
+ content::RenderProcessHost* process,
+ int routing_id)
+ : RenderWidgetHostImpl(delegate, process, routing_id),
prehandle_keyboard_event_(false),
prehandle_keyboard_event_called_(false),
prehandle_keyboard_event_type_(WebInputEvent::Undefined),
@@ -278,8 +290,10 @@ class RenderWidgetHostTest : public testing::Test {
// testing::Test
void SetUp() {
browser_context_.reset(new TestBrowserContext());
+ delegate_.reset(new MockRenderWidgetHostDelegate());
process_ = new RenderWidgetHostProcess(browser_context_.get());
- host_.reset(new MockRenderWidgetHost(process_, MSG_ROUTING_NONE));
+ host_.reset(
+ new MockRenderWidgetHost(delegate_.get(), process_, MSG_ROUTING_NONE));
view_.reset(new TestView(host_.get()));
host_->SetView(view_.get());
host_->Init();
@@ -287,6 +301,7 @@ class RenderWidgetHostTest : public testing::Test {
void TearDown() {
view_.reset();
host_.reset();
+ delegate_.reset();
process_ = NULL;
browser_context_.reset();
@@ -320,6 +335,7 @@ class RenderWidgetHostTest : public testing::Test {
scoped_ptr<TestBrowserContext> browser_context_;
RenderWidgetHostProcess* process_; // Deleted automatically by the widget.
+ scoped_ptr<MockRenderWidgetHostDelegate> delegate_;
scoped_ptr<MockRenderWidgetHost> host_;
scoped_ptr<TestView> view_;

Powered by Google App Engine
This is Rietveld 408576698