Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1365)

Unified Diff: content/browser/web_contents/web_drag_dest_mac.mm

Issue 10377119: Plumb event flags (shift/alt/ctrl modifiers) for drag/drop events to WebKit. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/web_contents/web_drag_dest_mac.mm
diff --git a/content/browser/web_contents/web_drag_dest_mac.mm b/content/browser/web_contents/web_drag_dest_mac.mm
index dd945fcaf7187b7dc49b88c9339bc071029915fb..5fe64222145a1df2a17df5e06e47a01bd44d473f 100644
--- a/content/browser/web_contents/web_drag_dest_mac.mm
+++ b/content/browser/web_contents/web_drag_dest_mac.mm
@@ -111,7 +111,8 @@ using content::Referrer;
*dropData_,
gfx::Point(viewPoint.x, viewPoint.y),
gfx::Point(screenPoint.x, screenPoint.y),
- static_cast<WebDragOperationsMask>(mask));
+ static_cast<WebDragOperationsMask>(mask),
+ 0 /* shift/ctrl/alt flags */);
jam 2012/05/15 16:57:53 nit: personally, I'm not a fan of adding comments
varunjain 2012/05/15 23:03:39 Done.
// We won't know the true operation (whether the drag is allowed) until we
// hear back from the renderer. For now, be optimistic:
@@ -154,7 +155,8 @@ using content::Referrer;
webContents_->GetRenderViewHost()->DragTargetDragOver(
gfx::Point(viewPoint.x, viewPoint.y),
gfx::Point(screenPoint.x, screenPoint.y),
- static_cast<WebDragOperationsMask>(mask));
+ static_cast<WebDragOperationsMask>(mask),
+ 0 /* shift/ctrl/alt flags */);
if (delegate_)
delegate_->OnDragOver();
@@ -194,7 +196,8 @@ using content::Referrer;
NSPoint screenPoint = [self flipWindowPointToScreen:windowPoint view:view];
webContents_->GetRenderViewHost()->DragTargetDrop(
gfx::Point(viewPoint.x, viewPoint.y),
- gfx::Point(screenPoint.x, screenPoint.y));
+ gfx::Point(screenPoint.x, screenPoint.y),
+ 0 /* shift/ctrl/alt flags */);
dropData_.reset();

Powered by Google App Engine
This is Rietveld 408576698