Send the correct referrer and policy when saving a file via PPAPI

content/browser/web_contents/web_contents_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/web_contents_impl.h"
 
 #include <utility>
 
 #include "base/command_line.h"
 #include "base/metrics/histogram.h"
@@ skipping 1191 matching lines @@
          contents_mime_type_ == "text/plain" ||
          contents_mime_type_ == "text/css" ||
          net::IsSupportedJavascriptMimeType(contents_mime_type_.c_str());
 }
 
 void WebContentsImpl::OnSavePage() {
   // If we can not save the page, try to download it.
   if (!IsSavable()) {
     download_stats::RecordDownloadSource(
         download_stats::INITIATED_BY_SAVE_PACKAGE_ON_NON_HTML);
-    SaveURL(GetURL(), GURL(), true);
+    SaveURL(GetURL(), content::Referrer(), true);
     return;
   }
 
   Stop();
 
   // Create the save package and possibly prompt the user for the name to save
   // the page as. The user prompt is an asynchronous operation that runs on
   // another thread.
   save_package_ = new SavePackage(this);
   save_package_->GetSaveInfo();
@@ skipping 509 matching lines @@
 }
 
 void WebContentsImpl::OnUpdateZoomLimits(int minimum_percent,
                                          int maximum_percent,
                                          bool remember) {
   minimum_zoom_percent_ = minimum_percent;
   maximum_zoom_percent_ = maximum_percent;
   temporary_zoom_settings_ = !remember;
 }
 
-void WebContentsImpl::OnSaveURL(const GURL& url) {
+void WebContentsImpl::OnSaveURL(const GURL& url,
+                                const content::Referrer& referrer) {
   download_stats::RecordDownloadSource(
       download_stats::INITIATED_BY_PEPPER_SAVE);
   // Check if the URL to save matches the URL of the main frame. Since this
   // message originates from Pepper plugins, it may not be the case if the
   // plugin is an embedded element.
   GURL main_frame_url = GetURL();
   if (!main_frame_url.is_valid())
     return;
   bool is_main_frame = (url == main_frame_url);
-  SaveURL(url, main_frame_url, is_main_frame);
+  SaveURL(url, referrer, is_main_frame);
 }
 
 void WebContentsImpl::OnEnumerateDirectory(int request_id,
                                            const FilePath& path) {
   ChildProcessSecurityPolicyImpl* policy =
       ChildProcessSecurityPolicyImpl::GetInstance();
   if (policy->CanReadDirectory(GetRenderProcessHost()->GetID(), path))
     delegate_->EnumerateDirectory(this, request_id, path);
 }
 
@@ skipping 933 matching lines @@
   static_cast<RenderViewHostImpl*>(
       rvh)->JavaScriptDialogClosed(reply_msg, success, user_input);
 }
 
 void WebContentsImpl::SetEncoding(const std::string& encoding) {
   encoding_ = content::GetContentClient()->browser()->
       GetCanonicalEncodingNameByAliasName(encoding);
 }
 
 void WebContentsImpl::SaveURL(const GURL& url,
-                              const GURL& referrer,
+                              const content::Referrer& referrer,
                               bool is_main_frame) {
   DownloadManager* dlm = GetBrowserContext()->GetDownloadManager();
   if (!dlm)
     return;
   int64 post_id = -1;
   if (is_main_frame) {
     const NavigationEntry* entry = controller_.GetActiveEntry();
     if (entry)
       post_id = entry->GetPostID();
   }
   content::DownloadSaveInfo save_info;
   save_info.prompt_for_save_location = true;
   scoped_ptr<DownloadUrlParameters> params(
       DownloadUrlParameters::FromWebContents(this, url, save_info));
-  params->set_referrer(referrer);
+  // TODO(jochen): Pass in the referrer policy as well.

[benjhayden, 2012/05/14 13:56:20]

Any reason not to do this in this cl?

[jochen (gone - plz use gerrit), 2012/05/14 14:11:22]

Yes, because then I need to change all places that use DownloadUrlParameters at
the same time. The idea is to first get the referrer to all places where
DownloadUrlParameters is created in individual CLs, and once that's done, switch
DownloadUrlParameters to actually use that

+  params->set_referrer(referrer.url);
   params->set_post_id(post_id);
   params->set_prefer_cache(true);
   if (post_id >= 0)
     params->set_method("POST");
   dlm->DownloadUrl(params.Pass());
 }
 
 void WebContentsImpl::CreateViewAndSetSizeForRVH(RenderViewHost* rvh) {
   RenderWidgetHostView* rwh_view = GetView()->CreateViewForWidget(rvh);
   // Can be NULL during tests.
   if (rwh_view)
     rwh_view->SetSize(GetView()->GetContainerSize());
 }
 
 RenderViewHostImpl* WebContentsImpl::GetRenderViewHostImpl() {
   return static_cast<RenderViewHostImpl*>(GetRenderViewHost());
 }