Issue 10377115: Refactored NetworkConfigurationUpdater to read policy from the PolicyService.

Issue 10377115: Refactored NetworkConfigurationUpdater to read policy from the PolicyService. (Closed)

Created:
8 years, 7 months ago by Joao da Silva

Modified:
8 years, 7 months ago

Reviewers:
Mattias Nissler (ping if slow)

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Refactored NetworkConfigurationUpdater to read policy from the PolicyService. This is part of the refactor of ConfigurationPolicyProvider, and removal of ConfigurationPolicyProvider::Provide(). BUG=108993 TEST=ONC works as before, tests are green Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137395

Patch Set 1 #

Patch Set 2 : Fixed build #

Patch Set 3 : Invoke callbacks the right way #

Total comments: 3

Patch Set 4 : Addressed comment #

Patch Set 5 : Rebased #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+61 lines, -51 lines)			Patch
M	chrome/browser/policy/browser_policy_connector.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/network_configuration_updater.h	View		2 chunks	+13 lines, -16 lines	0 comments	Download
M	chrome/browser/policy/network_configuration_updater.cc	View	1 2 3	2 chunks	+39 lines, -32 lines	0 comments	Download
M	chrome/browser/policy/network_configuration_updater_unittest.cc	View	1 2 3	4 chunks	+8 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

This one depends on http://codereview.chromium.org/10386097/ It's part of the removal of ConfigurationPolicyProvider::Provide(). Please review, thanks!

8 years, 7 months ago (2012-05-12 09:47:23 UTC) #1

Mattias Nissler (ping if slow)

LGTM with a nit and a comment that you probably don't want to address in ...

8 years, 7 months ago (2012-05-14 08:14:25 UTC) #2

Mattias Nissler (ping if slow)

Oh, and thou shalt not work on weekends!

8 years, 7 months ago (2012-05-14 08:15:01 UTC) #3

Joao da Silva

Thanks for the review! http://codereview.chromium.org/10377115/diff/9001/chrome/browser/policy/network_configuration_updater.cc File chrome/browser/policy/network_configuration_updater.cc (right): http://codereview.chromium.org/10377115/diff/9001/chrome/browser/policy/network_configuration_updater.cc#newcode38 chrome/browser/policy/network_configuration_updater.cc:38: device_update_callback); On 2012/05/14 08:14:25, Mattias ...

8 years, 7 months ago (2012-05-16 09:36:03 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/10377115/15001

8 years, 7 months ago (2012-05-16 09:36:16 UTC) #5

Change committed as 137395

Expand Messages | Collapse Messages