SpeechInputExtensionManager now interface with SpeechRecognitionManagerDelegate

content/public/browser/speech_recognition_session_context.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_PUBLIC_BROWSER_SPEECH_RECOGNITION_SESSION_CONTEXT_H_
 #define CONTENT_PUBLIC_BROWSER_SPEECH_RECOGNITION_SESSION_CONTEXT_H_
 #pragma once
 
+#include "base/string16.h"
 #include "content/common/content_export.h"
 #include "ui/gfx/rect.h"
 
 namespace content {
 
 // The context information required by clients of the SpeechRecognitionManager
 // and its delegates for mapping the recognition session to other browser
 // elements involved with it (e.g., the page element that requested the
 // recognition). The SpeechRecognitionManager is not aware of the content of
 // this struct and does NOT use it for its purposes. However the manager keeps
 // this struct "attached" to the recognition session during all the session
 // lifetime, making its contents available to clients (In this regard, see
 // SpeechRecognitionManager::GetSessionContext and
 // SpeechRecognitionManager::LookupSessionByContext methods).
 struct CONTENT_EXPORT SpeechRecognitionSessionContext {
-  SpeechRecognitionSessionContext()
-      : render_process_id(0),
-        render_view_id(0),
-        render_request_id(0),
-        js_handle_id(0) {}
-  ~SpeechRecognitionSessionContext() {}
+  SpeechRecognitionSessionContext();
+  ~SpeechRecognitionSessionContext();
 
   int render_process_id;
   int render_view_id;
   int render_request_id;
   int js_handle_id;
+
+  // Determines whether recognition shall use an active bubble on a page element
+  // (which coordinates are passed in |element_rect|) or a background tray icon.
+  bool use_bubble_on_element;

[Satish, 2012/05/20 21:40:26]

similar to jam's comment below, the concept of bubble should really be confined
to the chrome/ layer. I'm guessing in this case webkit is setting this flag to
true for x-webkit-speech api and false for JS API - if this is correct the
variable should probably be named accordingly (e.g. invoked_by_page_element) and
the chrome/ layer decides that it maps to whether it should show a bubble
attached to the element or not

[Primiano Tucci (use gerrit), 2012/05/21 16:03:13]

Right, renamed to requested_by_page_element

+
+  // The coordinates of the page element for placing the bubble (valid only when
+  // |use_bubble_on_element| = true).
   gfx::Rect element_rect;
+
+  // Determines whether a security notification balloon shall pop-up together
+  // with the tray icon (valid only when |use_bubble_on_element| = false).
+  bool show_security_balloon;

[jam, 2012/05/17 16:45:16]

this is a chrome concept and doesn't belong in content, i.e. different embedders
of content may treat security UI differently

[Primiano Tucci (use gerrit), 2012/05/21 16:03:13]

Renamed and added a TODO, since it will be removed very soon (but in the
meanwhile I need it in this CL to keep the behavior of speech input extensions
consistent).

+
+  // A texual description of the context (website, extension name) that is
+  // requesting recognition, for prompting security notifications to the user.
+  string16 context_name;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_PUBLIC_BROWSER_SPEECH_RECOGNITION_SESSION_CONTEXT_H_