Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1778)

Unified Diff: chrome/browser/chrome_browser_main.cc

Issue 10377033: Uselessly use the uniformity field trial. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chrome_browser_main.cc
diff --git a/chrome/browser/chrome_browser_main.cc b/chrome/browser/chrome_browser_main.cc
index 13c414b92a347fbea9507408a43fa7f417883cbf..4c666e7a8016f4b4cf9531f042ea3265a28c4b19 100644
--- a/chrome/browser/chrome_browser_main.cc
+++ b/chrome/browser/chrome_browser_main.cc
@@ -1082,6 +1082,11 @@ void ChromeBrowserMainParts::SetupUniformityFieldTrials() {
experiments_helper::AssociateGoogleExperimentID(trial_name, group_name,
static_cast<chrome_variations::ID>(trial_base_ids[i] + group_number));
}
+
+ // Now that all groups have been appended, call group() on the trial to
+ // ensure that our trial is registered. This resolves an off-by-one issue
+ // where the default group never gets chosen if we don't "use" the trial.
+ trial->group();
MAD 2012/05/07 14:47:19 Maybe a DVLOG(1) with the chosen group ID could be
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698