Issue 10377033: Uselessly use the uniformity field trial.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10377033: Uselessly use the uniformity field trial. (Closed)

Created:
8 years, 7 months ago by SteveT

Modified:
8 years, 7 months ago

Reviewers:
MAD

CC:
chromium-reviews, jwd

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Uselessly use the uniformity field trial. This resolves an off by one error where the default group is never selected and reported. BUG=126465 TEST=Ensure that the server is receiving Variation IDs for the default groups in the uniformity trials (such as 3300000 and 3300100). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135655

Patch Set 1 #

Total comments: 1

Patch Set 2 : DVLOG the group #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/browser/chrome_browser_main.cc	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

MAD

LGTM with an optional request... Thanks! BYE MAD http://codereview.chromium.org/10377033/diff/1/chrome/browser/chrome_browser_main.cc File chrome/browser/chrome_browser_main.cc (right): http://codereview.chromium.org/10377033/diff/1/chrome/browser/chrome_browser_main.cc#newcode1089 chrome/browser/chrome_browser_main.cc:1089: trial->group(); ...

8 years, 7 months ago (2012-05-07 14:47:18 UTC) #2

SteveT

Done. Looks like the release compiler is OK with this. I'll CQ presently.

8 years, 7 months ago (2012-05-07 15:12:55 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevet@chromium.org/10377033/4002

8 years, 7 months ago (2012-05-07 15:13:16 UTC) #4

Change committed as 135655

Expand Messages | Collapse Messages