Issue 10377004: one more localStrings => loadTimeData in extension_list.js

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10377004: one more localStrings => loadTimeData in extension_list.js (Closed)

Created:
8 years, 7 months ago by Evan Stade

Modified:
8 years, 7 months ago

Reviewers:
Mihai Parparita -not on Chrome

CC:
chromium-reviews, mihaip-chromium-reviews_chromium.org, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

one more localStrings => loadTimeData in extension_list.js (this occurred because r135152 was started before, but landed after, r133296) BUG=none TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135268

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	chrome/browser/resources/extensions/extension_list.js	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/10377004/1

8 years, 7 months ago (2012-05-03 23:48:01 UTC) #3

Aaron Boodman

8 years, 7 months ago (2012-05-04 02:01:14 UTC) #5

I just spent 30 minutes trying to figure out how my change caused this problem.
FYI.