Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6449)

Unified Diff: chrome/browser/resources/chromeos/login/oobe_screen_user_image.js

Issue 10376003: Improve accessibility of user image selection screen. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase, simplify change so it doesn't affect other uses of Grid/List Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/chromeos/login/oobe_screen_user_image.js
diff --git a/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js b/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js
index cb782ee1c733a3ee9a3ee21d50f827c2a9955525..0723cb70bdfd85211d6dc27debf52ee4ee5a7642 100644
--- a/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js
+++ b/chrome/browser/resources/chromeos/login/oobe_screen_user_image.js
@@ -394,6 +394,10 @@ cr.define('oobe', function() {
});
this.updateLocalizedContent();
+
+ window.setTimeout(function() {
+ console.error('\n\n' + document.body.innerHTML + '\n');
Ivan Korotkov 2012/08/03 01:00:23 Cleanup?
dmazzoni 2012/08/03 22:59:01 Done.
+ }, 10000);
},
/**
@@ -532,13 +536,13 @@ cr.define('oobe', function() {
/**
* Appends received images to the list.
- * @param {Array.<string>} images An array of URLs to user images.
+ * @param {Array.<Object>} imageInfos An array of data about user images.
* @private
*/
- setUserImages_: function(images) {
+ setUserImages_: function(imageInfos) {
Ivan Korotkov 2012/08/03 01:00:23 There are two distinct implementations in this fil
dmazzoni 2012/08/03 22:59:01 Ah - I thought the top one was going to go away. T
Ivan Korotkov 2012/08/03 23:19:37 It is, but we're keeping both of them operational
var imageGrid = $('user-image-grid');
- for (var i = 0, url; url = images[i]; i++)
- imageGrid.addItem(url).type = 'default';
+ for (var i = 0, imageInfo; imageInfo = imageInfos[i]; i++)
Ivan Korotkov 2012/08/03 01:00:23 Indentation & add parens, please.
dmazzoni 2012/08/03 22:59:01 Done.
+ imageGrid.addItem(imageInfo.url, imageInfo.title).type = 'default';
},
/**

Powered by Google App Engine
This is Rietveld 408576698