Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6502)

Unified Diff: chrome/browser/resources/shared/js/cr/ui/list_item.js

Issue 10376003: Improve accessibility of user image selection screen. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/shared/js/cr/ui/list_item.js
diff --git a/chrome/browser/resources/shared/js/cr/ui/list_item.js b/chrome/browser/resources/shared/js/cr/ui/list_item.js
index a670a1f27f424f5fffc8623a2abbcedb3c5c5445..5d7d3e321d34926d430e8eb9bb6c18b0b4495aa0 100644
--- a/chrome/browser/resources/shared/js/cr/ui/list_item.js
+++ b/chrome/browser/resources/shared/js/cr/ui/list_item.js
@@ -36,7 +36,7 @@ cr.define('cr.ui', function() {
* Called when an element is decorated as a list item.
*/
decorate: function() {
- this.setAttribute('role', 'listitem');
Ivan Korotkov 2012/05/04 17:02:27 This can break multiple styles on different pages.
dmazzoni 2012/05/04 17:48:00 Good catch. Actually I do want to fix this becaus
Ivan Korotkov 2012/05/04 22:03:33 Ok then. I hope you've caught all the listitem CSS
+ this.setAttribute('role', 'option');
},
/**

Powered by Google App Engine
This is Rietveld 408576698