chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc - Issue 10376003: Improve accessibility of user image selection screen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc

Issue 10376003: Improve accessibility of user image selection screen. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/shared/js/cr/ui/list_selection_controller.js ('K') | « chrome/browser/resources/shared/js/cr/ui/list_selection_controller.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc

diff --git a/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc b/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc

index 6da2ad41e3dbf81e9f24fa5e724b929563d76e1a..44abc35191bb398cd287bde79da466ac45af82d4 100644

--- a/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc

+++ b/chrome/browser/ui/webui/chromeos/login/user_image_screen_handler.cc

@@ -65,7 +65,10 @@ void UserImageScreenHandler::GetLocalizedStrings(

void UserImageScreenHandler::Initialize() {

ListValue image_urls;

for (int i = 0; i < kDefaultImagesCount; ++i) {

- image_urls.Append(new StringValue(GetDefaultImageUrl(i)));

+ DictionaryValue* dict = new DictionaryValue();

+ dict->Set("url", new StringValue(GetDefaultImageUrl(i)));

+ dict->Set("title", new StringValue(GetDefaultImageDescription(i)));

+ image_urls.Append(dict);

}

web_ui()->CallJavascriptFunction("oobe.UserImageScreen.setUserImages",

image_urls);