Improve accessibility of user image selection screen.

chrome/browser/resources/chromeos/login/oobe_screen_user_image.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Oobe user image screen implementation.
  */
 
 cr.define('oobe', function() {
   var UserImagesGrid = options.UserImagesGrid;
@@ skipping 376 matching lines @@
           'click', function(e) {
             previewElement.classList.add('animation');
             imageGrid.flipPhoto = !imageGrid.flipPhoto;
           });
       $('user-image-stream-crop').addEventListener(
           'webkitTransitionEnd', function(e) {
             previewElement.classList.remove('animation');
           });
 
       this.updateLocalizedContent();
+
+      window.setTimeout(function() {
+        console.error('\n\n' + document.body.innerHTML + '\n');

[Ivan Korotkov, 2012/08/03 01:00:23]

Cleanup?

[dmazzoni, 2012/08/03 22:59:01]

Done.

+      }, 10000);
     },
 
     /**
      * Header text of the screen.
      * @type {string}
      */
     get header() {
       return localStrings.getString('userImageScreenTitle');
     },
 
@@ skipping 118 matching lines @@
     setProfileImage_: function(imageUrl) {
       this.profileImageLoading = false;
       if (imageUrl !== null) {
         this.profileImage_ =
             $('user-image-grid').updateItem(this.profileImage_, imageUrl);
       }
     },
 
     /**
      * Appends received images to the list.
-     * @param {Array.<string>} images An array of URLs to user images.
+     * @param {Array.<Object>} imageInfos An array of data about user images.
      * @private
      */
-    setUserImages_: function(images) {
+    setUserImages_: function(imageInfos) {

[Ivan Korotkov, 2012/08/03 01:00:23]

There are two distinct implementations in this file, looks like you only changed
one of them.

[dmazzoni, 2012/08/03 22:59:01]

Ah - I thought the top one was going to go away. Thanks.

[Ivan Korotkov, 2012/08/03 23:19:37]

It is, but we're keeping both of them operational for now.

       var imageGrid = $('user-image-grid');
-      for (var i = 0, url; url = images[i]; i++)
-        imageGrid.addItem(url).type = 'default';
+        for (var i = 0, imageInfo; imageInfo = imageInfos[i]; i++)

[Ivan Korotkov, 2012/08/03 01:00:23]

Indentation & add parens, please.

[dmazzoni, 2012/08/03 22:59:01]

Done.

+          imageGrid.addItem(imageInfo.url, imageInfo.title).type = 'default';
     },
 
     /**
      * Selects user image with the given URL.
      * @param {string} url URL of the image to select.
      * @private
      */
     setSelectedImage_: function(url) {
       var imageGrid = $('user-image-grid');
       imageGrid.selectedItemUrl = url;
@@ skipping 37 matching lines @@
   ].forEach(function(name) {
     UserImageScreen[name] = function(value) {
       $('user-image')[name + '_'](value);
     };
   });
 
   return {
     UserImageScreen: UserImageScreen
   };
 });