Issue 10375014: Return NULL from base::Thread::message_loop_proxy() when thread is not started.

Issue 10375014: Return NULL from base::Thread::message_loop_proxy() when thread is not started. (Closed)

Created:
8 years, 7 months ago by Sergey Ulanov

Modified:
8 years, 7 months ago

Reviewers:
Do not use (sergeyu), willchan no longer on Chromium

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, dcaiafa+watch_chromium.org, wez+watch_chromium.org, erikwright (departed), amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, brettw-cc_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Return NULL from base::Thread::message_loop_proxy() when thread is not started. Previously that method was crashing when called when thread is not running Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135470

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -2 lines)			Patch
	M	base/threading/thread.h	View	1	1 chunk	+1 line, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

lgtm http://codereview.chromium.org/10375014/diff/2001/base/threading/thread.h File base/threading/thread.h (right): http://codereview.chromium.org/10375014/diff/2001/base/threading/thread.h#newcode120 base/threading/thread.h:120: // TODO(sanjeevr): Look into merging MessageLoop and MessageLoopProxy. ...

8 years, 7 months ago (2012-05-04 19:00:57 UTC) #2

Do not use (sergeyu)

http://codereview.chromium.org/10375014/diff/2001/base/threading/thread.h File base/threading/thread.h (right): http://codereview.chromium.org/10375014/diff/2001/base/threading/thread.h#newcode120 base/threading/thread.h:120: // TODO(sanjeevr): Look into merging MessageLoop and MessageLoopProxy. On ...

8 years, 7 months ago (2012-05-04 21:01:35 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/10375014/4

8 years, 7 months ago (2012-05-04 21:06:31 UTC) #4

Change committed as 135470

Expand Messages | Collapse Messages