Implement user selected wallpaper feature.

chrome/browser/resources/options2/chromeos/set_wallpaper_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
 
   var OptionsPage = options.OptionsPage;
   var UserImagesGrid = options.UserImagesGrid;
 
+  /** @const */ var CustomWallpaperPrefix = 'chrome://wallpaper/custom_';

[James Hawkins, 2012/05/06 15:49:50]

nit: Variables start lowerCase.

However, this is a const so it should be all caps.

[bshe, 2012/05/08 22:22:18]

Done.

+
   /////////////////////////////////////////////////////////////////////////////
   // SetWallpaperOptions class:
 
   /**
    * Encapsulated handling of ChromeOS set wallpaper options page.
    * @constructor
    */
   function SetWallpaperOptions() {
     OptionsPage.call(
         this,
@@ skipping 20 matching lines @@
 
       wallpaperGrid.addEventListener('change',
                                      this.handleImageSelected_.bind(this));
       wallpaperGrid.addEventListener('dblclick',
                                      this.handleImageDblClick_.bind(this));
       wallpaperGrid.addEventListener('activate',
                                      function() { OptionsPage.closeOverlay() });
 
       $('random-wallpaper-checkbox').addEventListener('click',
           this.handleCheckboxClick_.bind(this));
+      $('set-custome-wallpaper').addEventListener('click',
+          this.handleChooseFile_);
+      $('set-wallpaper-layout').addEventListener('change',
+          this.handleLayoutChange_);
       $('set-wallpaper-overlay-confirm').onclick = function() {
         OptionsPage.closeOverlay();
       };
 
       // @type {Array.<author: string, url: string, website: string>}
       this.wallpapers_ = [];
 
+      this.oldImage_ = null;

[James Hawkins, 2012/05/06 15:49:50]

Document.

[bshe, 2012/05/08 22:22:18]

Done.

+
       chrome.send('onSetWallpaperPageInitialized');
     },
 
     /**
      * Called right after the page has been shown to user.
      */
     didShowPage: function() {
       $('wallpaper-grid').updateAndFocus();
       // A quick hack to fix issue 118472. This is a general problem of list
       // control and options overlay.
       // TODO(bshe): Remove this hack when we fixed the general problem which
       // tracked in issue 118829.
       $('wallpaper-grid').redraw();
       chrome.send('onSetWallpaperPageShown');
     },
 
     /**
      * Called right before the page is hidden.
      */
     willHidePage: function() {
       var wallpaperGrid = $('wallpaper-grid');
       wallpaperGrid.blur();
+      if (this.oldImage_) {
+        wallpaperGrid.removeItem(this.oldImage_);
+        this.oldImage_ = null;
+      }
+      $('set-wallpaper-layout').innerText = '';
     },
 
     /**
      * Set attributions of wallpaper with given URL.
      * @param {string} url URL of the selected wallpaper.
      * @private
      */
     setWallpaperAttribution_: function(url) {
       for (var i = 0; i < this.wallpapers_.length; i++) {
         if (this.wallpapers_[i].url == url) {
           $('author-name').textContent = this.wallpapers_[i].author;
           $('author-website').textContent = this.wallpapers_[i].website;
           return;
         }
       }
       $('author-name').textContent = '';
       $('author-website').textContent = '';
     },
 
     /**
+     * Populate the drop down box for custom wallpaper layout.
+     * param {string} layouts Available wallpaper layout.

[flackr, 2012/05/04 19:06:17]

s/layout/layouts

[bshe, 2012/05/08 22:22:18]

Done.

+     * param {number} selectedLayout The value of selected/default layout.
+     * @private
+     */
+    populateWallpaperLayout_: function(layouts, selectedLayout) {

[flackr, 2012/05/04 19:06:17]

s/populateWallpaperLayout/populateWallpaperLayouts

[bshe, 2012/05/08 22:22:18]

Done.

+      var wallpaperLayout = $('set-wallpaper-layout');
+      var selectedIndex = -1;
+      for (var i = 0; i < layouts.length; i++) {
+        var option = new Option(layouts[i]['name'], layouts[i]['index']);
+        if (selectedLayout == option.value)
+          selectedIndex = i;
+        wallpaperLayout.appendChild(option);
+      }
+      if (selectedIndex >= 0)
+        wallpaperLayout.selectedIndex = selectedIndex;
+    },
+
+    /**
+     * Handles "Custom..." button activation.
+     * @private
+     */
+    handleChooseFile_: function() {
+      chrome.send('chooseWallpaper');
+    },
+
+    /**
+     * Handle the wallpaper layout setting change.
+     * @private
+     */
+    handleLayoutChange_: function() {
+      var setWallpaperLayout = $('set-wallpaper-layout');
+      var layout = setWallpaperLayout.options[
+          setWallpaperLayout.selectedIndex].value;
+      //var value = event.target.options[event.target.selectedIndex].value;

[flackr, 2012/05/04 19:06:17]

Remove commented code.

[bshe, 2012/05/08 22:22:18]

Done.

+      chrome.send('changeWallpaperLayout', [layout]);
+    },
+
+    /**
      * Handles image selection change.
      * @private
      */
     handleImageSelected_: function() {
       var wallpaperGrid = $('wallpaper-grid');
       var url = wallpaperGrid.selectedItemUrl;
       if (url &&
           !wallpaperGrid.inProgramSelection) {
+        if (url.indexOf(CustomWallpaperPrefix) != -1) {

[flackr, 2012/05/04 19:06:17]

This is strictly a prefix right? Maybe if == 0?

[bshe, 2012/05/08 22:22:18]

Done.

+          // User custom wallpaper is selected
+          $('set-wallpaper-layout').hidden = false;
+          $('attribution-label').hidden = true;
+          // When users select the custom wallpaper thumbnail from picker UI,
+          // use the saved layout value and redraw the wallpaper.
+          this.handleLayoutChange_();
+        } else {
+          $('set-wallpaper-layout').hidden = true;
+          $('attribution-label').hidden = false;
+          chrome.send('selectDefaultWallpaper', [url]);
+        }
         this.setWallpaperAttribution_(url);
-        chrome.send('selectDefaultWallpaper', [url]);
       }
     },
 
     /**
      * Handles double click on the image grid.
      * @param {Event} e Double click Event.
      */
     handleImageDblClick_: function(e) {
       var wallpaperGrid = $('wallpaper-grid');
       if (wallpaperGrid.disabled)
         return;
       // Close page unless the click target is the grid itself.
       if (e.target instanceof HTMLImageElement)
         OptionsPage.closeOverlay();
     },
 
     /**
      * Handles click on the "I'm feeling lucky" checkbox.
      * @private
      */
     handleCheckboxClick_: function() {
       var wallpaperGrid = $('wallpaper-grid');
       if ($('random-wallpaper-checkbox').checked) {
         wallpaperGrid.disabled = true;
+        $('attribution-label').hidden = false;
         chrome.send('selectRandomWallpaper');
         wallpaperGrid.classList.add('grayout');
+        $('set-wallpaper-layout').hidden = true;
       } else {
         wallpaperGrid.disabled = false;
         wallpaperGrid.classList.remove('grayout');
         // Set the wallpaper type to User::DEFAULT.
         this.handleImageSelected_();
       }
     },
 
     /**
      * Selects corresponding wallpaper thumbnail with the given URL and toggle
@@ skipping 27 matching lines @@
       // TODO(bshe): Ideally we should save author and website with the actual
       // image (URL) and not use index related storage. This way this data is
       // stored in one place rather than depending on the index to be
       // consistent.
       for (var i = 0, wallpaper; wallpaper = wallpapers[i]; i++) {
         this.wallpapers_.push(wallpaper);
         wallpaperGrid.addItem(wallpaper.url);
       }
     },
 
+    /**
+     * Called when user select a valid file from file system. Display layout
+     * drop down box and disable random mode if enabled.
+     */
+    didSelectFile_: function() {
+      $('set-wallpaper-layout').hidden = false;
+      var wallpaperGrid = $('wallpaper-grid');
+      if ($('random-wallpaper-checkbox').checked) {
+        $('random-wallpaper-checkbox').checked = false;
+        wallpaperGrid.disabled = false;
+        wallpaperGrid.classList.remove('grayout');
+      }
+    },
+
+    /**
+     * Get url of current user's custom wallpaper thumbnail.
+     */
+    get currentWallpaperImageUrl() {
+      return CustomWallpaperPrefix + BrowserOptions.getLoggedInUsername() +
+          '?id=' + (new Date()).getTime();

[flackr, 2012/05/04 19:06:17]

This is non-trivial and non-deterministic, I think you should use a regular
function for this.

[bshe, 2012/05/08 22:22:18]

Done.

+    },
+
+    /**
+     * Adds or updates custom user wallpaper thumbnail from file.
+     * @private
+     */
+    setCustomImage_: function() {
+      var wallpaperGrid = $('wallpaper-grid');
+      var url = this.currentWallpaperImageUrl;
+      if (this.oldImage_) {
+        this.oldImage_ = wallpaperGrid.updateItem(this.oldImage_, url);
+      } else {
+        // Insert to the end of wallpaper list.
+        var pos = wallpaperGrid.length;
+        this.oldImage_ = wallpaperGrid.addItem(url, undefined, undefined, pos);
+      }
+
+      // Clear attributions for custom wallpaper.
+      $('attribution-label').hidden = true;
+      this.setWallpaperAttribution_('');
+      wallpaperGrid.selectedItem = this.oldImage_;
+      // Enable the layout drop down box when custom wallpaper is selected.
+      $('set-wallpaper-layout').hidden = false;

[flackr, 2012/05/04 19:06:17]

We're updating the visibility of attribution-label and set-wallpaper-layout in
many places with the same conditions (custom, !custom), this should be
consolidated this into a single method.

[bshe, 2012/05/08 22:22:18]

Done.

+    },
   };
 
   // Forward public APIs to private implementations.
   [
     'setDefaultImages',
-    'setSelectedImage'
+    'setSelectedImage',
+    'populateWallpaperLayout',
+    'didSelectFile',
+    'setCustomImage'
   ].forEach(function(name) {
     SetWallpaperOptions[name] = function() {
       var instance = SetWallpaperOptions.getInstance();
       return instance[name + '_'].apply(instance, arguments);
     };
   });
 
   // Export
   return {
     SetWallpaperOptions: SetWallpaperOptions
   };
 
 });