chrome/renderer/resources/extensions/content_settings_custom_bindings.js - Issue 10367002: Make all extension api types fully qualified.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/resources/extensions/content_settings_custom_bindings.js

Issue 10367002: Make all extension api types fully qualified. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: tests pass, docs are updated, it's g2g I think Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/common/extensions/api/extension_api.cc ('K') | « chrome/common/extensions/docs/windows.html ('k') | chrome/renderer/resources/extensions/storage_custom_bindings.js » ('j') | tools/json_schema_compiler/cpp_type_generator.py » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/renderer/resources/extensions/content_settings_custom_bindings.js

diff --git a/chrome/renderer/resources/extensions/content_settings_custom_bindings.js b/chrome/renderer/resources/extensions/content_settings_custom_bindings.js

index d07cb69c48eeacfd3bdf0739961cf8ec530dc6a1..826ff4553bd0e412da8569be70a03287a0fa5279 100644

--- a/chrome/renderer/resources/extensions/content_settings_custom_bindings.js

+++ b/chrome/renderer/resources/extensions/content_settings_custom_bindings.js

@@ -7,7 +7,7 @@

var chromeHidden = requireNative('chrome_hidden').GetChromeHidden();

var sendRequest = require('sendRequest').sendRequest;

-chromeHidden.registerCustomType('ContentSetting', function() {

+chromeHidden.registerCustomType('contentSettings.ContentSetting', function() {

function extendSchema(schema) {

var extendedSchema = schema.slice();

extendedSchema.unshift({'type': 'string'});