Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 10365016: Add a dependency on remoting_webapp to chromium_builder_qa. (Closed)

Created:
8 years, 7 months ago by simonmorris
Modified:
8 years, 7 months ago
Reviewers:
Wez, Nirnimesh
CC:
chromium-reviews
Visibility:
Public.

Description

Add a dependency on remoting_webapp to chromium_builder_qa. The pyauto chromoting test expects the webapp to be available. This CL makes it available when that test is run on the builders. BUG=126278 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135438

Patch Set 1 #

Patch Set 2 : Rephrase comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M build/all.gyp View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
simonmorris
PTAL
8 years, 7 months ago (2012-05-04 18:38:03 UTC) #1
Nirnimesh
LGTM
8 years, 7 months ago (2012-05-04 18:47:20 UTC) #2
Wez
lgtm
8 years, 7 months ago (2012-05-04 18:54:53 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonmorris@chromium.org/10365016/4
8 years, 7 months ago (2012-05-04 19:39:22 UTC) #4
commit-bot: I haz the power
8 years, 7 months ago (2012-05-04 21:18:06 UTC) #5
Change committed as 135438

Powered by Google App Engine
This is Rietveld 408576698