lib/compiler/implementation/compiler.dart - Issue 10363003: Compute function types together with the parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/compiler/implementation/compiler.dart

Issue 10363003: Compute function types together with the parameters. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « lib/compiler/implementation/compile_time_constants.dart ('k') | lib/compiler/implementation/elements/elements.dart » ('j') | lib/compiler/implementation/elements/elements.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: lib/compiler/implementation/compiler.dart

diff --git a/lib/compiler/implementation/compiler.dart b/lib/compiler/implementation/compiler.dart

index e6fccd66d0e50542bf4e39ec122bd6ffd0f538b6..2511173e4de6ef1606b6e7b36dfc404953e65f80 100644

--- a/lib/compiler/implementation/compiler.dart

+++ b/lib/compiler/implementation/compiler.dart

@@ -292,7 +292,7 @@ class Compiler implements DiagnosticListener {

cancel('main is not a function', element: main);

}

FunctionElement mainMethod = main;

- FunctionParameters parameters = mainMethod.computeParameters(this);

+ FunctionSignature parameters = mainMethod.computeSignature(this);

if (parameters.parameterCount > 0) {

cancel('main cannot have parameters', element: mainMethod);

}

@@ -420,7 +420,7 @@ class Compiler implements DiagnosticListener {

return resolver.resolveTypeAnnotation(element, annotation);

}

- FunctionParameters resolveSignature(FunctionElement element) {

+ FunctionSignature resolveSignature(FunctionElement element) {

return withCurrentElement(element,

() => resolver.resolveSignature(element));

}