Add chromium-side support for history.{push,replace}State.

Add chromium-side support for history.{push,replace}State.

Enables the feature so that all but 2 of the related layout tests pass.

Modifies TestShell to correctly update its location bar as navigations occur.
It was incorrectly showing firstPartyForCookies for some crazy reason.

Modifies glue_serialize.cc to store the state object associated with a session
history entry.

Modifies navigation_controller.cc to always replace the current navigation
entry when observing an in-page navigation.  This is required since the page ID
isn't changing for an in-page navigation.

BUG=29393
R=brettw
TEST=covered by layout tests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41850

[brettw, 2010-03-16 23:25:25]

http://codereview.chromium.org/1036003/diff/10001/11006
File chrome/browser/tab_contents/navigation_controller.cc (right):

http://codereview.chromium.org/1036003/diff/10001/11006#newcode782
chrome/browser/tab_contents/navigation_controller.cc:782: const
ViewHostMsg_FrameNavigate_Params& params, bool* did_replace_entry) {
This parameter is never set any more. Should it be deleted? What about a unit
test?

[darin (slow to review), 2010-03-16 23:52:30]

good catch.  yeah, i should add a unit test.  i think some ui tests would be
good as well.

[darin (slow to review), 2010-03-17 07:00:53]

OK, now featuring a NavigationControllerTest.  I decided against UI tests.  I
may come back to that.

[brettw_gmail.com, 2010-03-17 16:18:19]

LGTM

http://codereview.chromium.org/1036003/diff/29001/16011
File chrome/browser/tab_contents/navigation_controller_unittest.cc (right):

http://codereview.chromium.org/1036003/diff/29001/16011#newcode1127
chrome/browser/tab_contents/navigation_controller_unittest.cc:1127: // Main
page. Note that we need "://" so this URL is treated as "standard"
This "note" is wrong in this case (I guess you copied it from above). I'd just
remove it in both cases. Also, what's with the 4 slashes?