Beginnings of a debugger wire protocol

runtime/bin/main.cc

Index: runtime/bin/main.cc
===================================================================
--- runtime/bin/main.cc	(revision 7293)
+++ runtime/bin/main.cc	(working copy)
@@ -11,6 +11,7 @@
 
 #include "bin/builtin.h"
 #include "bin/dartutils.h"
+#include "bin/dbg_connection.h"
 #include "bin/directory.h"
 #include "bin/eventhandler.h"
 #include "bin/extensions.h"
@@ -46,6 +47,13 @@
 static const char* breakpoint_at = NULL;
 
 
+// Global state that indicates whether we should open a connection
+// and listen for a debugger to connect.
+static bool start_debugger = false;
+static const int DEFAULT_DEBUG_PORT = 5858;
+static int debug_port = 0;
+
+
 // Value of the --package-root flag.
 // (This pointer points into an argv buffer and does not need to be
 // free'd.)
@@ -84,6 +92,26 @@
 }
 
 
+static void ProcessDebugOption(const char* port) {
+  ASSERT(port != NULL);
+  debug_port = 0;
+  if (*port == '\0') {
+    debug_port = DEFAULT_DEBUG_PORT;
+  } else {
+    if ((*port == '=') || (*port == ':')) {
+      debug_port = atoi(port + 1);
+    }
+  }
+  if (debug_port == 0) {
+    fprintf(stderr, "unrecognized --debug option syntax. "
+                    "Use --debug[:<port number>]\n");

[siva, 2012/05/03 22:52:08]

see comment regarding having this option be
--debug=[<address>:]<port_number>

[hausner, 2012/05/03 23:52:00]

Done.

+    return;
+  }
+  breakpoint_at = "main";

[siva, 2012/05/03 22:52:08]

Maybe later on this should also be a command line option i.e people may chose to
have the VM wait on main for a debugger to attach or just run and allow for a
debugger to attach later and use the OOB mechanism to interrupt the running
program.

[hausner, 2012/05/03 23:52:00]

I agree. For now, I need this because I can't interrupt the running isolate.

On 2012/05/03 22:52:08, asiva wrote:

+  start_debugger = true;
+}
+
+
 static void ProcessPprofOption(const char* filename) {
   ASSERT(filename != NULL);
   generate_pprof_symbols_filename = filename;
@@ -102,6 +130,7 @@
 } main_options[] = {
   { "--break_at=", ProcessBreakpointOption },
   { "--compile_all", ProcessCompileAllOption },
+  { "--debug", ProcessDebugOption },
   { "--generate_pprof_symbols=", ProcessPprofOption },
   { "--import_map=", ProcessImportMapOption },
   { "--package-root=", ProcessPackageRootOption },
@@ -613,6 +642,13 @@
           Dart_GetError(result));
     }
   }
+
+  // Start the debugger wire protocol handler if necessary.
+  if (start_debugger) {
+    ASSERT(debug_port != 0);
+    DebuggerConnectionHandler::StartHandler(debug_port);
+  }
+
   // Lookup and invoke the top level main function.
   result = Dart_Invoke(library, Dart_NewString("main"), 0, NULL);
   if (Dart_IsError(result)) {