Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issue 10355014: Make checkout.*.prepare() to delete the svn:ignored files. (Closed)

Created:
8 years, 7 months ago by M-A Ruel
Modified:
8 years, 7 months ago
Reviewers:
Peter Mayo
CC:
chromium-reviews, Dirk Pranke, M-A Ruel
Visibility:
Public.

Description

Make checkout.*.prepare() delete the svn:ignored files. Add corresponding support to scm.SVN.Revert() to clobber the svn:ignore'd files. This makes the commit queue remove all the unversioned files, which could have improved its stability. It failed in practice to improve it but it's still a good thing to do overall. R=petermayo@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -7 lines) Patch
M checkout.py View 1 chunk +1 line, -1 line 0 comments Download
M scm.py View 3 chunks +5 lines, -3 lines 0 comments Download
M tests/gclient_scm_test.py View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
8 years, 7 months ago (2012-05-03 19:28:39 UTC) #1
M-A Ruel
grammar fixed. ptal.
8 years, 7 months ago (2012-05-04 14:03:59 UTC) #2
Peter Mayo
lgtm
8 years, 7 months ago (2012-05-04 14:06:31 UTC) #3
Peter Mayo
On 2012/05/04 14:03:59, Marc-Antoine Ruel wrote: > grammar fixed. ptal. Thanks.
8 years, 7 months ago (2012-05-04 14:07:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10355014/1
8 years, 7 months ago (2012-05-04 14:09:47 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-04 14:16:33 UTC) #6
Change committed as 135333

Powered by Google App Engine
This is Rietveld 408576698