Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2389)

Issue 10352022: ash: Fix regression where system tray clock wasn't updated. (Closed)

Created:
8 years, 7 months ago by Daniel Erat
Modified:
8 years, 7 months ago
CC:
chromium-reviews, sadrul, ben+watch_chromium.org, Rick Byers
Visibility:
Public.

Description

ash: Fix regression where system tray clock wasn't updated. I suspect that I broke this in r134585. BUG=126155 TEST=manual: clock is updated after UI job starts Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135265

Patch Set 1 #

Patch Set 2 : update a comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M ash/system/date/date_view.h View 1 2 chunks +5 lines, -1 line 0 comments Download
M ash/system/date/date_view.cc View 2 chunks +7 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Daniel Erat
8 years, 7 months ago (2012-05-03 21:31:57 UTC) #1
Daniel Erat
8 years, 7 months ago (2012-05-03 22:44:08 UTC) #2
Ben Goodger (Google)
lgtm
8 years, 7 months ago (2012-05-03 22:46:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/10352022/2001
8 years, 7 months ago (2012-05-03 22:48:22 UTC) #4
commit-bot: I haz the power
Try job failure for 10352022-2001 (retry) on win_rel for step "update" (clobber build). It's a ...
8 years, 7 months ago (2012-05-03 23:28:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/10352022/2001
8 years, 7 months ago (2012-05-03 23:29:35 UTC) #6
commit-bot: I haz the power
Try job failure for 10352022-2001 on win_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=25604 Step "update" is always ...
8 years, 7 months ago (2012-05-03 23:41:16 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/10352022/2001
8 years, 7 months ago (2012-05-03 23:43:58 UTC) #8
commit-bot: I haz the power
8 years, 7 months ago (2012-05-04 01:18:04 UTC) #9
Change committed as 135265

Powered by Google App Engine
This is Rietveld 408576698