Allow "float-abi" to be configurable at gyp time for ARM build

The background is that we are to enable hardfp build for  chrome browser.

Currently, the '-mfloat-abi=soft' is hard coded in the gyp file, but what we need is "-mfloat-abi=hard", since it is hard-coded, we no way to change it.

So this CL removed this hard-coded value, replaced it with variable arm_float_abi, which has a default value of 'soft'.   Later in the ebuild file, we can easily override this value to be 'hard', thus make the build hardfp.

BUG=None
TEST=build manually in chromium


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135388

[Han, 2012-05-03 20:51:35]

Hi I'm from chromiumos toolchain team, we are trying to enable hardfp build for
the whole system.

Could you take a look at this CL?

Thanks,
-Han

[Elliot Glaysher, 2012-05-03 20:55:27]

I have no idea what this is.

On Thu, May 3, 2012 at 1:51 PM,  <shenhan@google.com> wrote:
> Reviewers: Elliot Glaysher, tony, sail, Alpha,
>
> Message:
> Hi I'm from chromiumos toolchain team, we are trying to enable hardfp build
> for
> the whole system.
>
> Could you take a look at this CL?
>
> Thanks,
> -Han
>
> Description:
> Remvoed hard-coded 'softfp' flag in build file.
>
> The background is that we are to enable hardfp build for  chrome browser.
>
> BUG=None
> TEST=build manually in chromium
>
>
> Please review this at https://chromiumcodereview.appspot.com/10351018/
>
> SVN Base: http://git.chromium.org/chromium/src.git@master
>
> Affected files:
>  M build/common.gypi
>
>
> Index: build/common.gypi
> diff --git a/build/common.gypi b/build/common.gypi
> index
>
451b1e9704846b18990b8c6ee3a1b4950e4526b4..5716e61e098bd38ab20f6d8444b7c5556cdd4b9d
> 100644
> --- a/build/common.gypi
> +++ b/build/common.gypi
> @@ -725,6 +725,9 @@
>     # arm_neon==0).
>     'arm_fpu%': 'vfpv3',
>
> +    # Set ARM float abi compilation flag.
> +    'arm_float_abi%': 'softfp',
> +
>     # Enable new NPDevice API.
>     'enable_new_npdevice_api%': 0,
>
> @@ -2075,7 +2078,7 @@
>                     'cflags': [
>                       '-march=armv7-a',
>                       '-mtune=cortex-a8',
> -                      '-mfloat-abi=softfp',
> +                      '-mfloat-abi=<(arm_float_abi)',
>                     ],
>                     'conditions': [
>                       ['arm_neon==1', {
>
>

[Han, 2012-05-03 21:00:41]

Hi Elliot, sorry, I've updated the description to be more specific.

Currently, the '-mfloat-abi=soft' is hard coded in the gyp file, but what we
need is "-mfloat-abi=hard", since it is hard-coded, we have no way to change it.

So this CL removed this hard-coded value, replaced it with variable
arm_float_abi, which has a default value of 'soft'. Later in the ebuild file, we
can easily override this value to be 'hard', thus make the build hardfp.


On 2012/05/03 20:55:27, Elliot Glaysher wrote:
> I have no idea what this is.
> 
> On Thu, May 3, 2012 at 1:51 PM,  <mailto:shenhan@google.com> wrote:
> > Reviewers: Elliot Glaysher, tony, sail, Alpha,
> >
> > Message:
> > Hi I'm from chromiumos toolchain team, we are trying to enable hardfp build
> > for
> > the whole system.
> >
> > Could you take a look at this CL?
> >
> > Thanks,
> > -Han
> >
> > Description:
> > Remvoed hard-coded 'softfp' flag in build file.
> >
> > The background is that we are to enable hardfp build for &nbsp;chrome
browser.
> >
> > BUG=None
> > TEST=build manually in chromium
> >
> >
> > Please review this at https://chromiumcodereview.appspot.com/10351018/
> >
> > SVN Base: http://git.chromium.org/chromium/src.git%40master
> >
> > Affected files:
> > &nbsp;M build/common.gypi
> >
> >
> > Index: build/common.gypi
> > diff --git a/build/common.gypi b/build/common.gypi
> > index
> >
>
451b1e9704846b18990b8c6ee3a1b4950e4526b4..5716e61e098bd38ab20f6d8444b7c5556cdd4b9d
> > 100644
> > --- a/build/common.gypi
> > +++ b/build/common.gypi
> > @@ -725,6 +725,9 @@
> > &nbsp; &nbsp; # arm_neon==0).
> > &nbsp; &nbsp; 'arm_fpu%': 'vfpv3',
> >
> > + &nbsp; &nbsp;# Set ARM float abi compilation flag.
> > + &nbsp; &nbsp;'arm_float_abi%': 'softfp',
> > +
> > &nbsp; &nbsp; # Enable new NPDevice API.
> > &nbsp; &nbsp; 'enable_new_npdevice_api%': 0,
> >
> > @@ -2075,7 +2078,7 @@
> > &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
'cflags': [
> > &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
'-march=armv7-a',
> > &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
'-mtune=cortex-a8',
> > - &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp;'-mfloat-abi=softfp',
> > + &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp;'-mfloat-abi=<(arm_float_abi)',
> > &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; ],
> > &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
'conditions': [
> > &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
['arm_neon==1', {
> >
> >

[tony, 2012-05-03 21:10:08]

LGTM, but the change description is confusing.  It sounds like you're removing a
cflag, but you're just making it configurable at gyp time.  Maybe something
like, "Allow float-abi to be configurable at gyp time for ARM build."

[Han, 2012-05-03 21:12:16]

On 2012/05/03 21:10:08, tony wrote:
> LGTM, but the change description is confusing.  It sounds like you're removing
a
> cflag, but you're just making it configurable at gyp time.  Maybe something
> like, "Allow float-abi to be configurable at gyp time for ARM build."


Thanks Tony, yup, modified the CL description.

[Elliot Glaysher, 2012-05-03 21:57:19]

lgtm if tony is happy with it

(in general, I'm not the best reviewer for low level abi and compiler errata
stuff.)

[Han, 2012-05-04 18:03:31]

On 2012/05/03 21:57:19, Elliot Glaysher wrote:
> lgtm if tony is happy with it
> 
> (in general, I'm not the best reviewer for low level abi and compiler errata
> stuff.)

Hi any one can help land this for me? There are other CLs pending on this one. 

Thanks,
-Han

[commit-bot: I haz the power, 2012-05-04 18:05:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/shenhan@google.com/10351018/1

[commit-bot: I haz the power, 2012-05-04 19:26:43]

Change committed as 135388