Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(500)

Issue 10351013: Return a list of plugins that support clearing site data instead of the first one. (Closed)

Created:
8 years, 7 months ago by Bernhard Bauer
Modified:
8 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Return a list of plugins that support clearing site data instead of the first one. BUG=126089 TEST=see bug for manual test Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135497

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -16 lines) Patch
M chrome/browser/plugin_data_remover_helper.cc View 1 chunk +8 lines, -3 lines 0 comments Download
M content/browser/plugin_data_remover_impl.cc View 1 chunk +9 lines, -10 lines 0 comments Download
M content/public/browser/plugin_data_remover.h View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Bernhard Bauer
Please review.
8 years, 7 months ago (2012-05-04 12:59:41 UTC) #1
jam
http://codereview.chromium.org/10351013/diff/1/content/public/browser/plugin_data_remover.h File content/public/browser/plugin_data_remover.h (right): http://codereview.chromium.org/10351013/diff/1/content/public/browser/plugin_data_remover.h#newcode34 content/public/browser/plugin_data_remover.h:34: // XXX ?
8 years, 7 months ago (2012-05-04 16:37:32 UTC) #2
Bernhard Bauer
http://codereview.chromium.org/10351013/diff/1/content/public/browser/plugin_data_remover.h File content/public/browser/plugin_data_remover.h (right): http://codereview.chromium.org/10351013/diff/1/content/public/browser/plugin_data_remover.h#newcode34 content/public/browser/plugin_data_remover.h:34: // XXX On 2012/05/04 16:37:32, John Abd-El-Malek wrote: > ...
8 years, 7 months ago (2012-05-04 17:05:14 UTC) #3
jam
lgtm
8 years, 7 months ago (2012-05-04 17:07:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/10351013/11001
8 years, 7 months ago (2012-05-04 22:30:28 UTC) #5
commit-bot: I haz the power
8 years, 7 months ago (2012-05-05 00:45:45 UTC) #6
Change committed as 135497

Powered by Google App Engine
This is Rietveld 408576698