Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 10350011: Add a variations header file where all Chrome variation IDs are declared and stored. (Closed)

Created:
8 years, 7 months ago by SteveT
Modified:
8 years, 7 months ago
CC:
chromium-reviews, MAD, Ilya Sherman, jar (doing other things), sreeram
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add a variations header file where all Chrome variation IDs are declared and stored. Modify the existing experiments_helper APIs and tests to use the new chrome_variations::ID type. BUG=none TEST=Ensure that unit_tests ExperimentsHelperTest.* all pass. TBR=mad@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135256

Patch Set 1 : init #

Total comments: 8

Patch Set 2 : asvit comments #

Total comments: 8

Patch Set 3 : asvit nits #

Patch Set 4 : kEmptyID #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -54 lines) Patch
M chrome/common/metrics/experiments_helper.h View 1 2 3 4 chunks +23 lines, -26 lines 2 comments Download
M chrome/common/metrics/experiments_helper.cc View 1 2 3 4 chunks +9 lines, -10 lines 0 comments Download
M chrome/common/metrics/experiments_helper_unittest.cc View 1 2 3 6 chunks +16 lines, -18 lines 0 comments Download
A chrome/common/metrics/variation_ids.h View 1 2 3 1 chunk +70 lines, -0 lines 2 comments Download

Messages

Total messages: 17 (0 generated)
SteveT
As discussed - PTAL!
8 years, 7 months ago (2012-05-03 18:26:09 UTC) #1
Alexei Svitkine (slow)
https://chromiumcodereview.appspot.com/10350011/diff/3002/chrome/common/metrics/experiments_helper.cc File chrome/common/metrics/experiments_helper.cc (right): https://chromiumcodereview.appspot.com/10350011/diff/3002/chrome/common/metrics/experiments_helper.cc#newcode98 chrome/common/metrics/experiments_helper.cc:98: const chrome_variations::ID kEmptyGoogleExperimentID = Should this be part of ...
8 years, 7 months ago (2012-05-03 18:45:05 UTC) #2
SteveT
Over to you. Thanks for the first look. https://chromiumcodereview.appspot.com/10350011/diff/3002/chrome/common/metrics/experiments_helper.cc File chrome/common/metrics/experiments_helper.cc (right): https://chromiumcodereview.appspot.com/10350011/diff/3002/chrome/common/metrics/experiments_helper.cc#newcode98 chrome/common/metrics/experiments_helper.cc:98: const ...
8 years, 7 months ago (2012-05-03 19:05:08 UTC) #3
Alexei Svitkine (slow)
Thanks! https://chromiumcodereview.appspot.com/10350011/diff/12002/chrome/common/metrics/variation_ids.h File chrome/common/metrics/variation_ids.h (right): https://chromiumcodereview.appspot.com/10350011/diff/12002/chrome/common/metrics/variation_ids.h#newcode38 chrome/common/metrics/variation_ids.h:38: // please ensure that they are within the ...
8 years, 7 months ago (2012-05-03 19:14:53 UTC) #4
SteveT
Nits addressed. Back to you. https://chromiumcodereview.appspot.com/10350011/diff/12002/chrome/common/metrics/variation_ids.h File chrome/common/metrics/variation_ids.h (right): https://chromiumcodereview.appspot.com/10350011/diff/12002/chrome/common/metrics/variation_ids.h#newcode38 chrome/common/metrics/variation_ids.h:38: // please ensure that ...
8 years, 7 months ago (2012-05-03 19:27:02 UTC) #5
Alexei Svitkine (slow)
LGTM
8 years, 7 months ago (2012-05-03 19:30:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevet@chromium.org/10350011/5005
8 years, 7 months ago (2012-05-03 19:37:07 UTC) #7
commit-bot: I haz the power
Try job failure for 10350011-5005 on win_rel for step "update". http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=25474 Step "update" is always ...
8 years, 7 months ago (2012-05-03 19:52:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevet@chromium.org/10350011/5005
8 years, 7 months ago (2012-05-03 19:58:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevet@chromium.org/10350011/5012
8 years, 7 months ago (2012-05-03 20:16:12 UTC) #10
MAD
Sorry for the delay, I know this is in the CQ right now, but I ...
8 years, 7 months ago (2012-05-03 20:44:04 UTC) #11
SteveT
Let me know if this is satisfactory. https://chromiumcodereview.appspot.com/10350011/diff/5012/chrome/common/metrics/experiments_helper.h File chrome/common/metrics/experiments_helper.h (left): https://chromiumcodereview.appspot.com/10350011/diff/5012/chrome/common/metrics/experiments_helper.h#oldcode49 chrome/common/metrics/experiments_helper.h:49: typedef uint32 ...
8 years, 7 months ago (2012-05-03 21:04:03 UTC) #12
commit-bot: I haz the power
List of reviewers changed. mad@chromium.org did a drive-by without LGTM'ing!
8 years, 7 months ago (2012-05-03 22:47:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevet@chromium.org/10350011/5012
8 years, 7 months ago (2012-05-03 22:51:38 UTC) #14
SteveT
MAD - I'm committing with you TBR since I believe your concerns are addressed... also ...
8 years, 7 months ago (2012-05-03 22:53:02 UTC) #15
commit-bot: I haz the power
Change committed as 135256
8 years, 7 months ago (2012-05-04 00:48:51 UTC) #16
MAD
8 years, 7 months ago (2012-05-04 15:43:41 UTC) #17
lgtm

Powered by Google App Engine
This is Rietveld 408576698