Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Issue 10350010: Add the chromoting PyAuto test to the CONTINUOUS suite. (Closed)

Created:
8 years, 7 months ago by simonmorris
Modified:
8 years, 7 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, dennis_jeffrey, anantha, dyu1
Visibility:
Public.

Description

Add the chromoting PyAuto test to the CONTINUOUS suite. BUG=126278 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135266

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/test/functional/PYAUTO_TESTS View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
simonmorris
PTAL The trybot results don't look very helpful, but chromoting_basic succeeded on mac_rel .
8 years, 7 months ago (2012-05-03 21:50:52 UTC) #1
Nirnimesh
LGTM
8 years, 7 months ago (2012-05-03 23:32:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/simonmorris@chromium.org/10350010/1
8 years, 7 months ago (2012-05-03 23:33:44 UTC) #3
commit-bot: I haz the power
Change committed as 135266
8 years, 7 months ago (2012-05-04 01:19:52 UTC) #4
simonmorris
On 2012/05/03 23:32:14, Nirnimesh wrote: > LGTM codereview.chromium.org/10365016 should fix the problem that led to ...
8 years, 7 months ago (2012-05-07 15:48:41 UTC) #5
Nirnimesh
8 years, 7 months ago (2012-05-07 19:17:12 UTC) #6
On 2012/05/07 15:48:41, simonmorris wrote:
> On 2012/05/03 23:32:14, Nirnimesh wrote:
> > LGTM
> 
> codereview.chromium.org/10365016 should fix the problem that led to this CL
> being reverted (codereview.chromium.org/10356011).
> 
> Please LGTM again if you're happy for me to re-submit this CL.

You could probably create a new CL.

Powered by Google App Engine
This is Rietveld 408576698