src/platform/power_manager/SConstruct - Issue 1035001: Fix off-by-one bug for the negative transition in XIdle::AddIdleTimeout, which

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/platform/power_manager/SConstruct

Issue 1035001: Fix off-by-one bug for the negative transition in XIdle::AddIdleTimeout, which (Closed)

Patch Set: Update to address Dan's comments Created 10 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # Copyright (c) 2009-2010 The Chromium OS Authors. All rights reserved.	1 # Copyright (c) 2009-2010 The Chromium OS Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4	4

5 import os	5 import os

6 import itertools	6 import itertools

7	7

8	8

9 Help('''\	9 Help('''\

10 Type: 'scons' to build and 'scons -c' to clean\	10 Type: 'scons' to build and 'scons -c' to clean\

(...skipping 21 matching lines...) Expand all Loading...
32	32

33 # Build example program	33 # Build example program

34 base_env.Append(LIBS=Split('base rt X11 Xext'))	34 base_env.Append(LIBS=Split('base rt X11 Xext'))

35 base_env.Append(CPPPATH=['..'])	35 base_env.Append(CPPPATH=['..'])

36 xidle = base_env.Library('xidle', ['xidle.cc'])	36 xidle = base_env.Library('xidle', ['xidle.cc'])

37 xidle_example = base_env.Program('xidle-example', ['xidle-example.cc', xidle])	37 xidle_example = base_env.Program('xidle-example', ['xidle-example.cc', xidle])

38 Default(xidle_example)	38 Default(xidle_example)

39	39

40 # Build unit tests	40 # Build unit tests

41 test_env = base_env.Clone()	41 test_env = base_env.Clone()

42 test_env.Append(LIBS=['gtest'])	42 test_env.Append(LIBS=['gtest','Xtst'])
	Daniel Erat 2010/03/16 21:40:01 nit: add a space after the comma nit: add a space after the comma
43 test_env.Program('xidle_unittest',	43 test_env.Program('xidle_unittest',

44 ['testrunner.cc', 'xidle_unittest.cc', xidle])	44 ['testrunner.cc', 'xidle_unittest.cc', xidle])

45 tests = []	45 tests = []

OLD	NEW

« no previous file with comments | « no previous file | src/platform/power_manager/xidle.h » ('j') | src/platform/power_manager/xidle.cc » ('J')