Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Issue 10349015: Make platform apps get isolated storage by default. (Closed)

Created:
8 years, 7 months ago by Mihai Parparita -not on Chrome
Modified:
8 years, 7 months ago
Reviewers:
Charlie Reis, sail
CC:
chromium-reviews, Aaron Boodman, mihaip-chromium-reviews_chromium.org
Visibility:
Public.

Description

Make platform apps get isolated storage by default. Also centralizes the checks for when isolated storage is applicable to happen in Extension::LoadAppIsolation, so that Extension::is_storage_isolated() don't have to check for the experimental permission anymore. R=creis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135269

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -19 lines) Patch
M chrome/browser/extensions/extension_service.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/extensions/platform_app_browsertest.cc View 2 chunks +32 lines, -0 lines 0 comments Download
M chrome/browser/profiles/off_the_record_profile_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/profiles/profile_impl.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/common/extensions/api/_manifest_features.json View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/common/extensions/extension.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension.cc View 2 chunks +16 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_platformapp_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
A chrome/test/data/extensions/platform_apps/isolation/manifest.json View 1 chunk +12 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/platform_apps/isolation/set_cookie.html View 1 chunk +9 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/platform_apps/isolation/test.js View 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Mihai Parparita -not on Chrome
8 years, 7 months ago (2012-05-03 20:44:06 UTC) #1
Charlie Reis
Nice! LGTM.
8 years, 7 months ago (2012-05-03 22:07:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/10349015/1
8 years, 7 months ago (2012-05-03 22:51:18 UTC) #3
commit-bot: I haz the power
Presubmit check for 10349015-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 7 months ago (2012-05-03 22:51:28 UTC) #4
Mihai Parparita -not on Chrome
Sailesh, mind LGTM-ing for chrome/browser/profiles?
8 years, 7 months ago (2012-05-03 22:53:28 UTC) #5
sail
profiles/* LGTM!
8 years, 7 months ago (2012-05-03 22:59:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mihaip@chromium.org/10349015/1
8 years, 7 months ago (2012-05-03 22:59:55 UTC) #7
commit-bot: I haz the power
8 years, 7 months ago (2012-05-04 01:36:58 UTC) #8
Change committed as 135269

Powered by Google App Engine
This is Rietveld 408576698