content/public/browser/render_widget_host_view.h - Issue 10349013: Prevent browser thumbnailer from trying to read from frontbuffer (surface texture) when none exists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/render_widget_host_view.h

Issue 10349013: Prevent browser thumbnailer from trying to read from frontbuffer (surface texture) when none exists. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fixing unittests and adding one EXPECT clause. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/public/browser/render_widget_host_view.h

diff --git a/content/public/browser/render_widget_host_view.h b/content/public/browser/render_widget_host_view.h

index f11a9f800446f05dfc15ad6b8b655dfb29066688..636d2ce0c60c7bfb954d1a2f112f937b02545042 100644

--- a/content/public/browser/render_widget_host_view.h

+++ b/content/public/browser/render_widget_host_view.h

@@ -82,6 +82,8 @@ class CONTENT_EXPORT RenderWidgetHostView {

virtual void Focus() = 0;

// Returns true if the View currently has the focus.

virtual bool HasFocus() const = 0;

+ // Returns true is the current display surface is available.

+ virtual bool HasSurface() const = 0;

mmocny 2012/05/03 19:46:08 This name is not nearly descriptive enough, but I

mazda 2012/05/03 20:19:33 This is also confusing because there is similar fu

mazda 2012/05/04 22:20:32 IsSurfaceAvailableForCopy in your latest patch loo

// Shows/hides the view. These must always be called together in pairs.

// It is not legal to call Hide() multiple times in a row.

« no previous file with comments | « content/browser/renderer_host/test_render_view_host.cc ('k') | no next file » | no next file with comments »