Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1601)

Unified Diff: content/browser/renderer_host/render_widget_host_view_aura.cc

Issue 10349013: Prevent browser thumbnailer from trying to read from frontbuffer (surface texture) when none exists. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: DCHECK protection against segfault. Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/render_widget_host_view_aura.cc
diff --git a/content/browser/renderer_host/render_widget_host_view_aura.cc b/content/browser/renderer_host/render_widget_host_view_aura.cc
index a61b5fa9acbb1529118b4e9d248a88003fdac636..13e8f1005b7005bd5e600421c308220b197766e1 100644
--- a/content/browser/renderer_host/render_widget_host_view_aura.cc
+++ b/content/browser/renderer_host/render_widget_host_view_aura.cc
@@ -332,6 +332,10 @@ bool RenderWidgetHostViewAura::HasFocus() const {
return window_->HasFocus();
}
+bool RenderWidgetHostViewAura::IsSurfaceAvailableForCopy() const {
+ return current_surface_ != 0;
+}
+
void RenderWidgetHostViewAura::Show() {
window_->Show();
}
@@ -448,6 +452,8 @@ void RenderWidgetHostViewAura::CopyFromCompositingSurface(
if (!compositor)
return;
+ DCHECK(image_transport_clients_.find(current_surface_) !=
+ image_transport_clients_.end());
mazda 2012/05/23 20:06:23 When this condition holds, |container| is initiali
mmocny 2012/05/23 20:28:30 You are right. The issue was that we expect the e
ImageTransportClient* container = image_transport_clients_[current_surface_];
if (!container)
return;

Powered by Google App Engine
This is Rietveld 408576698