content/browser/renderer_host/render_widget_host_view_mac.mm - Issue 10349013: Prevent browser thumbnailer from trying to read from frontbuffer (surface texture) when none exists.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_widget_host_view_mac.mm

Issue 10349013: Prevent browser thumbnailer from trying to read from frontbuffer (surface texture) when none exists. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Renaming HasSurface to IsSurfaceAvailableForCopy Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/tab_contents/thumbnail_generator.cc ('K') | « content/browser/renderer_host/render_widget_host_view_mac.h ('k') | content/browser/renderer_host/render_widget_host_view_win.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_widget_host_view_mac.mm

diff --git a/content/browser/renderer_host/render_widget_host_view_mac.mm b/content/browser/renderer_host/render_widget_host_view_mac.mm

index 155a2cfb2d7c748a3b11535244f3f6a234c447be..f4c3596a7a1fab099a36d955d34738cd3a23415c 100644

--- a/content/browser/renderer_host/render_widget_host_view_mac.mm

+++ b/content/browser/renderer_host/render_widget_host_view_mac.mm

@@ -514,6 +514,11 @@ bool RenderWidgetHostViewMac::HasFocus() const {

return [[cocoa_view_ window] firstResponder] == cocoa_view_;

}

+bool RenderWidgetHostViewMac::IsSurfaceAvailableForCopy() const {

+ return !!render_widget_host_->GetBackingStore(false) ||

+ (compositing_iosurface_.get() && compositing_iosurface_->HasIOSurface());

void RenderWidgetHostViewMac::Show() {

[cocoa_view_ setHidden:NO];