Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Issue 10348007: Remove some dead code in ThumbnailGenerator. (Closed)

Created:
8 years, 7 months ago by mazda
Modified:
8 years, 7 months ago
CC:
chromium-reviews, Avi (use Gerrit), ajwong+watch_chromium.org, creis+watch_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Remove some dead code in ThumbnailGenerator. The aim of this change is to remove the use of RenderWidgetHost::CopyFromBackingStore. |prefer_backing_store| in AskForSnapShot is always set to false, so I deleted the pass that executes only when true is set in order to remove GetBitmapForRenderWidgetHost, which eventually calls RenderWidgetHost::CopyFromBackingStore. BUG=120003 TEST=Checked tab overview works file Tests-Missing Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=135788

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -85 lines) Patch
M chrome/browser/tab_contents/thumbnail_generator.h View 1 2 1 chunk +6 lines, -23 lines 0 comments Download
M chrome/browser/tab_contents/thumbnail_generator.cc View 1 2 4 chunks +1 line, -60 lines 0 comments Download
M chrome/browser/ui/cocoa/tabpose_window.mm View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/base/ui_test_utils.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
mazda
Could you review this change? brettw: Overall change avi: chrome/browser/ui/cocoa Thanks,
8 years, 7 months ago (2012-05-05 04:58:31 UTC) #1
brettw
lgtm
8 years, 7 months ago (2012-05-07 22:23:32 UTC) #2
Avi (use Gerrit)
LGTM On Mon, May 7, 2012 at 6:23 PM, <brettw@chromium.org> wrote: > lgtm > > ...
8 years, 7 months ago (2012-05-07 22:38:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/10348007/17001
8 years, 7 months ago (2012-05-07 22:40:08 UTC) #4
commit-bot: I haz the power
Try job failure for 10348007-17001 (retry) on win_rel for step "update". It's a second try, ...
8 years, 7 months ago (2012-05-08 01:17:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mazda@chromium.org/10348007/17001
8 years, 7 months ago (2012-05-08 01:22:26 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-05-08 01:46:00 UTC) #7
Try job failure for 10348007-17001 on win_rel for step "update".
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

Powered by Google App Engine
This is Rietveld 408576698