gamepad: linux: use input device parent, not USB

gamepad: linux: use input device parent, not USB

The input device parent of a joystick device already has the vendor and
product id as well as a name attribute that combines the manufacturer
and product name, use this instead of the USB device parent giving us
support for non-USB (i.e. Bluetooth) gamepads.

BUG=chromium-os:30273
TEST=PS3 controller shows up with correct mappings when connected via Bluetooth.

Change-Id: Ifa9ed24a4c9b9a5b2c98aad862fc77a520233e0d

R=scottmg@chromium.org


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135272

[scottmg, 2012-05-02 22:24:06]

On 2012/05/02 21:50:23, keybuk wrote:

I just checked a couple pads, and this seems to cause a difference in the id
string. For example, before I get "Logitech Rumble Gamepad F510" and after I get
"Generic X-Box pad". (The PS3 is unchanged, and both have the correct/same
product and vendor seem correct).

Would it be possible to get that more specific name instead?

[keybuk, 2012-05-02 23:06:46]

There isn't an easy difference between a USB pad and a Bluetooth pad, we
wouldn't know that "Logitech Rumble Gamepad F510" is preferred and "Atheros
Bluetooth Host" isn't.

[scottmg, 2012-05-02 23:25:30]

On 2012/05/02 23:06:46, keybuk wrote:
> There isn't an easy difference between a USB pad and a Bluetooth pad, we
> wouldn't know that "Logitech Rumble Gamepad F510" is preferred and "Atheros
> Bluetooth Host" isn't.

I see, thanks. That's a shame, but I guess +bluetooth is worth
-human_readable_description. lgtm.

[keybuk, 2012-05-03 15:59:09]

On 2012/05/02 23:25:30, scottmg wrote:
> On 2012/05/02 23:06:46, keybuk wrote:
> > There isn't an easy difference between a USB pad and a Bluetooth pad, we
> > wouldn't know that "Logitech Rumble Gamepad F510" is preferred and "Atheros
> > Bluetooth Host" isn't.
> 
> I see, thanks. That's a shame, but I guess +bluetooth is worth
> -human_readable_description. lgtm.

I thought of a neat way of dealing with this: if the USB vendor/product id match
the input device, use the name from the USB device - if not, use the name from
the input device.

Will try it out this morning and if it works, update the patch.

[keybuk, 2012-05-03 17:28:04]

that worked just fine, please take another look

[scottmg, 2012-05-03 17:37:38]

excellent, thanks! lgtm with comment.

http://chromiumcodereview.appspot.com/10346009/diff/7001/content/browser/game...
File content/browser/gamepad/platform_data_fetcher_linux.cc (right):

http://chromiumcodereview.appspot.com/10346009/diff/7001/content/browser/game...
content/browser/gamepad/platform_data_fetcher_linux.cc:180: std::string id =
base::StringPrintf("%s (%sVendor: %s Product: %s)",
save name and remainder separately to avoid duplicating the sprintf code below

[keybuk, 2012-05-03 18:19:42]

ok, please check the separation

[scottmg, 2012-05-03 18:23:06]

lgtm

[scottmg, 2012-05-03 18:23:06]

lgtm

lgtm

[commit-bot: I haz the power, 2012-05-03 18:27:01]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/keybuk@chromium.org/10346009/11002

[commit-bot: I haz the power, 2012-05-03 18:27:07]

Presubmit check for 10346009-11002 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    content/browser

Presubmit checks took 3.1s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[keybuk, 2012-05-03 18:28:35]

+sky for OWNERS

[sky, 2012-05-03 19:14:33]

I don't know anything about this code. Is there another owner you can get to
review that knows about it?

[scottmg, 2012-05-03 19:24:21]

On 2012/05/03 19:14:33, sky wrote:
> I don't know anything about this code. Is there another owner you can get to
> review that knows about it?

jam did some of the original OWNERS reviews, but there isn't really anyone else
who knows much about the linux device details. non-OWNERS, erg and rsleevi had
some comments on the original code.

[sky, 2012-05-03 19:30:02]

Jam is still an owner. I added him.

[jam, 2012-05-03 22:45:21]

rubberstamp lgtm

[commit-bot: I haz the power, 2012-05-03 23:54:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/keybuk@chromium.org/10346009/11002

[commit-bot: I haz the power, 2012-05-04 01:47:53]

Change committed as 135272