Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(417)

Issue 10342021: FieldTrial - Use ObserverListThreadSafe instead of (Closed)

Created:
8 years, 7 months ago by ramant (doing other things)
Modified:
8 years, 7 months ago
CC:
chromium-reviews, erikwright (departed), MAD, Ilya Sherman, jar (doing other things), brettw-cc_chromium.org, SteveT
Visibility:
Public.

Description

FieldTrial - Use ObserverListThreadSafe instead of ObserverList. R=jar TEST=base unit tests BUG=126027 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135263

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -9 lines) Patch
M base/metrics/field_trial.h View 3 chunks +3 lines, -3 lines 0 comments Download
M base/metrics/field_trial.cc View 4 chunks +8 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
ramant (doing other things)
Hi Jim, If you have few minutes, would like to discuss this change with you. ...
8 years, 7 months ago (2012-05-03 21:02:24 UTC) #1
jar (doing other things)
lgtm
8 years, 7 months ago (2012-05-03 23:12:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rtenneti@chromium.org/10342021/1
8 years, 7 months ago (2012-05-03 23:20:56 UTC) #3
commit-bot: I haz the power
8 years, 7 months ago (2012-05-04 01:14:17 UTC) #4
Change committed as 135263

Powered by Google App Engine
This is Rietveld 408576698